Stellar Protocol 11 Compatibility #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnando
changed the title
|
@bartekn @morleyzhi this is up for review. |
|
@morleyzhi good call. Totally forgot about the changelog. Just pushed the update. |
morleyzhi
reviewed
May 1, 2019
| - Add Stellar Protocol 11 compatibility (breaking change) | ||
| - Rename `manage_offer` to `manage_sell_offer`. | ||
| - Rename `create_passive_offer` to `create_passive_sell_offer`. | ||
| - Add `manage_buy_offer`. |
There was a problem hiding this comment.
Some things I noticed:
- The breaking change warning isn't super visible. The changelog should have earlier updates that bold the words and put it at the beginning, I think it's worth maintaining that convention
- If I'm just a JS dev, I might not understand what implications this has to the API of the library, so it might make sense to frame this in terms of the library exports that are being added (I guess it's renaming
Operation.manageOffertoOperation.manageSellOffer?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #179
manage_offertomanage_sell_offercreate_passive_offertocreate_passive_sell_offermanage_buy_offer(CAP-0006)