Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellar Protocol 11 Compatibility #179

Closed
bartekn opened this issue Apr 29, 2019 · 3 comments · Fixed by #186
Closed

Stellar Protocol 11 Compatibility #179

bartekn opened this issue Apr 29, 2019 · 3 comments · Fixed by #186

Comments

@bartekn
Copy link
Contributor

bartekn commented Apr 29, 2019

Protocol V11 of Stellar adds a new manage_buy_offer operation. Also names of manage_offer and create_passive_offer have been changed to manage_sell_offer and create_passive_sell_offer.

References:

@bartekn bartekn changed the title New manage_buy_offer operation. New manage_buy_offer operation Apr 29, 2019
@morleyzhi
Copy link
Contributor

@bartekn That XDR files diff goes to a link that says "there isn't anything to compare", what actually needs to be done there?

@bartekn
Copy link
Contributor Author

bartekn commented Apr 29, 2019

Github rendered this link broken. Try this:

https://github.com/stellar/stellar-core/compare/v10.3.0...v11.0.0#diff-01cb6b2520b4d5097b53837c1c18c5a3

EDIT actually this link doesn't point to the files directly. In that diff view go to files and check files in src/xdr/ folder.

After copying new files you can use xdrgen (when stellar/xdrgen#44 is merged) to generate new JS code.

@theaeolianmachine theaeolianmachine changed the title New manage_buy_offer operation Stellar Protocol 11 Compatibility Apr 29, 2019
@fnando
Copy link
Member

fnando commented May 1, 2019

@bartekn should https://github.com/stellar/stellar-protocol/blob/master/core/cap-0006.md be amended? It's referencing ManageOffer, which is being replaced by ManageSellOffer.

Edit: never mind… only the abstract mentions ManageOffer, which makes sense.

morleyzhi pushed a commit that referenced this issue May 1, 2019
Close #179

- [x] rename `manage_offer` to `manage_sell_offer`
- [x] rename `create_passive_offer` to `create_passive_sell_offer `
- [x] add `manage_buy_offer` ([CAP-0006](https://github.com/stellar/stellar-protocol/blob/master/core/cap-0006.md))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants