Handle new RPC simulation response variations #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
requested review from
paulbellamy,
2opremio,
sreuland and
tsachiherman
paulbellamy
reviewed
Aug 23, 2023
sreuland
reviewed
Aug 23, 2023
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @types/[email protected], @types/[email protected] |
|
Note that this is targeting the |
This was referenced Sep 12, 2023
sreuland
reviewed
Sep 12, 2023
sreuland
reviewed
Sep 12, 2023
| const coalesced = parseRawSimulation(simulation); | ||
| if (!coalesced.result) { | ||
| throw new Error(`simulation incorrect: ${JSON.stringify(coalesced)}`); | ||
| let success = parseRawSimulation(simulation); |
There was a problem hiding this comment.
minor nit, your call, it's not success yet, maybe simulationResponse
There was a problem hiding this comment.
but it should be! heh. slightly more annoying to read later lines if it's something like parsed, and reassigning after the if (!isSuccess...) check is also slightly more annoying 🙃
sreuland
reviewed
Sep 12, 2023
sreuland
reviewed
Sep 12, 2023
sreuland
approved these changes
Sep 12, 2023
Shaptic
added a commit
that referenced
this pull request
Sep 13, 2023
* Upgrade the codebase to work with testnet XDR (#135) * Using [email protected] * Prepare `v1.0.0-beta.0` for release (#143) * Handle new RPC simulation response variations (#132) * Add Core build reference to changelog for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with stellar/stellar-cli#865 and stellar/stellar-cli#878. The new behavior is documented here. In summary:
The
idandlatestLedgerfields always exist. Then, there are branching variations:erroralways existstransactionData,minResourceFee, andcostalways existresultsonly exists IF the simulation was for an invocation oprestorePreambleonly exists IF the simulation required expired entrieseventsmay exist but we will make it always exist (maybe empty)Our transformations are as follows:
eventsalways exists (but may be empty)results?[]is coalesced into a singleresult?