Add fallback parsing to edge cases in simulateTransaction
.
#136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a Soroban RPC bug (stellar/soroban-rpc#20) in which
results
will have a result object that is invalid. TheparseRawSimulation
abstraction assumes a valid schema, so this changesretval
to be avoid
ScVal
in case of an invalid response.This also adds a way to make the raw JSON RPC request again,
Server._simulateTransaction()
, in order to prevent any internal parsing errors from affecting development. Developers can then just look at the JSON directly (it also helps with debugging).