Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose captive core version details #5332

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Jun 3, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Exposes captive core version details in captive-core-backend. This change is prerequisite for fixing stellar/stellar-rpc#161

Why

Currently getNetowrk and getVersionInfo endpoint calls /info on core client, which in theory can semi-block the core thread. We need to refactor captive core implementation to expose captive core version so that soroban-rpc does not fetch it using http client. (i.e cache it at core process level)

Known limitations

N/A

psheth9 added 2 commits June 3, 2024 16:06

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth
@psheth9 psheth9 marked this pull request as ready for review June 5, 2024 20:10
@psheth9 psheth9 requested a review from tamirms June 5, 2024 20:11
psheth9 added 3 commits June 10, 2024 11:34

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth
@tamirms
Copy link
Contributor

tamirms commented Jun 13, 2024

There is no function for accessing the version.

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth
@psheth9
Copy link
Contributor Author

psheth9 commented Jun 14, 2024

Fixed the review comments Thank you @tamirms :)

psheth9 added 2 commits June 14, 2024 14:19

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth

Verified

This commit was signed with the committer’s verified signature.
psheth9 Prit Sheth
@psheth9 psheth9 merged commit 3a31ed7 into master Jun 14, 2024
31 checks passed
@psheth9 psheth9 deleted the expose-protocol-version-captive-core branch June 14, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants