Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getNetwork and getVersionInfo endpoint to fetch captive core version without making http request to core-client #161

Closed
psheth9 opened this issue May 2, 2024 · 0 comments · Fixed by #198
Assignees

Comments

@psheth9
Copy link
Contributor

psheth9 commented May 2, 2024

What problem does your feature solve?

Currently getNetowrk and getVersionInfo endpoint calls /info on core client, which in theory can semi-block the core thread. We need to refactor captive core implementation to expose captive core version so that soroban-rpc does not fetch it using http client. (i.e cache it at core process level)

More context: #132 (comment)

What would you like to see?

  • Update captive_core_backend.go to expose ProtocolVersion instead of fetching from core client
  • Add caching or update version value when core process starts/restarts
  • Refactor getNetwork and getVersionInfo endpoint to fetch value from captive_core object instead of calling http client

What alternatives are there?

N/A

@psheth9 psheth9 self-assigned this May 2, 2024
@psheth9 psheth9 moved this from Backlog to To Do in Platform Scrum May 2, 2024
@mollykarcher mollykarcher added this to the platform sprint 48 milestone May 28, 2024
@psheth9 psheth9 changed the title Refactor getNetwork and getVersionInfo endpoint to fetch protocol version without making http request to core-client Refactor getNetwork and getVersionInfo endpoint to fetch captive core version without making http request to core-client Jun 3, 2024
@psheth9 psheth9 moved this from To Do to In Progress in Platform Scrum Jun 4, 2024
@psheth9 psheth9 moved this from In Progress to Needs Review in Platform Scrum Jun 10, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants