Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port 2.28.3 back to mainline #5215

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Port 2.28.3 back to mainline #5215

merged 5 commits into from
Feb 21, 2024

Conversation

sreuland
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

merging the changes that were done on 2.28.3 back to master

Why

to keep master up to date with released content.

Known limitations

tamirms and others added 4 commits February 18, 2024 23:25
@tamirms @sreuland
Fix claimable_balance_claimants subquery in GetClaimableBalances() (s…
798da16 
…tellar#5207)
@sreuland
/services/horizon/ingest: add SKIP_TXMETA (stellar#5208)
cae5b85 
* Revert "services/horizon: Add DISABLE_SOROBAN_INGEST flag to skip soroban ingestion processing (stellar#5176)"

This reverts commit bfaf9e1.

* stellar#5189: added optional SKIP_TXMETA parameter to not persist tx meta in transaction model, removed DISABLE_SOROBAN_INGEST, use SKIP_META instead
@sreuland
updated changelog for 2.28.3
03e1903
@sreuland
Merge remote-tracking branch 'upstream/master' into merge_2.28.3
a693b1e
@sreuland sreuland merged commit 84c21d0 into stellar:master Feb 21, 2024
29 checks passed
@sreuland
Copy link
Contributor Author

@Shaptic , thanks for the assist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

@urvisavla urvisavla Awaiting requested review from urvisavla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreuland @tamirms @Shaptic