services/horizon: Add DISABLE_SOROBAN_INGEST flag to skip soroban ingestion processing #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
force-pushed
the
5175/skip-soroban-ingestion-flag
branch
2 times, most recently
from
dd36e94 to
572fc72
Compare
urvisavla
commented
Jan 21, 2024
urvisavla
force-pushed
the
5175/skip-soroban-ingestion-flag
branch
from
572fc72 to
a11e6d7
Compare
…soroban ingestion processing
urvisavla
force-pushed
the
5175/skip-soroban-ingestion-flag
branch
from
a11e6d7 to
66342bb
Compare
urvisavla
commented
Jan 21, 2024
Shaptic
reviewed
Jan 22, 2024
…processors to prevent making changes in the individual processors.
urvisavla
force-pushed
the
5175/skip-soroban-ingestion-flag
branch
from
0860eb6 to
e5db60b
Compare
update soroban tests for disabled config
Shaptic
approved these changes
Jan 24, 2024
services/horizon/internal/ingest/processors/effects_processor.go
Outdated
Show resolved
Hide resolved
services/horizon/internal/ingest/processors/operations_processor.go
Outdated
Show resolved
Hide resolved
services/horizon/internal/integration/invokehostfunction_test.go
Outdated
Show resolved
Hide resolved
sreuland
changed the title
sreuland
pushed a commit
to sreuland/go
that referenced
this pull request
Jan 29, 2024
…estion processing (stellar#5176)
sreuland
added a commit
to sreuland/go
that referenced
this pull request
Feb 14, 2024
…oban ingestion processing (stellar#5176)" This reverts commit bfaf9e1.
7 tasks
sreuland
added a commit
to sreuland/go
that referenced
this pull request
Feb 20, 2024
* Revert "services/horizon: Add DISABLE_SOROBAN_INGEST flag to skip soroban ingestion processing (stellar#5176)" This reverts commit bfaf9e1. * stellar#5189: added optional SKIP_TXMETA parameter to not persist tx meta in transaction model, removed DISABLE_SOROBAN_INGEST, use SKIP_META instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Added
DISABLE_SOROBAN_INGEST_PROCESSORSflag to optionally skip Soroban related ingestion processing. It's set tofalseby default. #5175 provides specs on specific processes and storage points that are elided.Why
Fixes #5175
Known limitations
Manually tested. So would be good to add unit tests to validate the flag and correct processing skipping.