update soroban tests for disabled config #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
reviewed
Jan 23, 2024
| @@ -346,6 +377,22 @@ func assembleInstallContractCodeOp(t *testing.T, sourceAccount string, wasmFileN | |||
| } | |||
| } | |||
|
|
|||
| func verifyEmptySorobanMeta(t *testing.T, clientTx horizon.Transaction) { | |||
There was a problem hiding this comment.
Is this no longer used anywhere?
There was a problem hiding this comment.
good call out, I meant to still use this when DisabledSoroban=true in the test cases, I'll push that up to your branch directly in a bit, as i'm stepping through that per our huddle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@urvisavla , this is a draft of the changes i think needed on soroban integration tests to handle when DISABLE_SOROBAN_INGEST_PROCESSORS=true|false