Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/ingest: removed legacy core cursor update against during ledger ingestion #5158

Merged

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Jan 10, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Removed the core cursor update that is attempted by ingest fsm on each ledger, as it was only relevant to legacy core db ingestion which is no longer enabled, only captive core ingestion.

Removed the configuration flags --stellar-core-url-db, --cursor-name --skip-cursor-update , as they are related to legacy core db ingestion which is no longer usable.

if one of the aforementioned flags is present, horizon will exit and report the error on console

$ DATABASE_URL=dburl STELLAR_CORE_DATABASE_URL=xxx ./horizon
flag --stellar-core-db-url and environment variable STELLAR_CORE_DATABASE_URL have been removed and no longer valid, must use captive core configuration for ingestion

Closes #5153

Why

discovered the un-necessary core cursor update taking time during performance benchmarking.

Known limitations

@sreuland sreuland requested a review from a team January 11, 2024 00:27
@@ -273,13 +272,6 @@ func NewSystem(config Config) (System, error) {
cancel()
return nil, errors.Wrap(err, "error creating captive core backend")
}
} else {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unreachable code, config.RemoteCaptiveCoreEnabled() is the inverse of config.LocalCaptiveCoreEnabled(), horizon assumes only captive core.

Copy link
Contributor

@urvisavla urvisavla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sreuland sreuland merged commit 428a0be into stellar:release-horizon-v2.28.0 Jan 11, 2024
28 checks passed
sreuland added a commit to sreuland/go that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants