Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to update cursor when ingesting from captive core #5153

Closed
tamirms opened this issue Jan 5, 2024 · 1 comment
Closed

No need to update cursor when ingesting from captive core #5153

tamirms opened this issue Jan 5, 2024 · 1 comment
Assignees
@sreuland
Labels
bug horizon ingest New ingestion system performance issues aimed at improving performance

Comments

@tamirms
Copy link
Contributor

tamirms commented Jan 5, 2024

As @sreuland reported, we always update the cursor via the stellar core client in the resume state:

https://github.com/stellar/go/blob/master/services/horizon/internal/ingest/fsm.go#L526

We should only be doing this if we're running legacy ingestion via the stellar core postgres DB. When running captive core, there is no need to update the cursor.
@tamirms tamirms added the bug label Jan 5, 2024
@mollykarcher mollykarcher added horizon performance issues aimed at improving performance labels Jan 5, 2024
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Jan 5, 2024
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Jan 5, 2024
@sreuland sreuland moved this from Current Sprint to In Progress in Platform Scrum Jan 8, 2024
@sreuland sreuland self-assigned this Jan 8, 2024
@sreuland sreuland added the ingest New ingestion system label Jan 8, 2024
sreuland added a commit to sreuland/go that referenced this issue Jan 10, 2024
@sreuland
stellar#5153: removed cursor update against core during ledger ingest…
a7e2ab6 
…ion and unused core db related config flags
@sreuland sreuland mentioned this issue Jan 10, 2024
Merged
7 tasks
@sreuland sreuland moved this from In Progress to Needs Review in Platform Scrum Jan 10, 2024
@sreuland sreuland mentioned this issue Jan 10, 2024
Closed
sreuland added a commit to sreuland/go that referenced this issue Jan 11, 2024
@sreuland
stellar#5153: removed remotecaptivecoreurl config var, it's no longer…
a781a11 
… referenced
@sreuland
Copy link
Contributor

#5158 merged

@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
bug horizon ingest New ingestion system performance issues aimed at improving performance
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tamirms @mollykarcher @sreuland