-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingestion fastbatch cbp #5085
Ingestion fastbatch cbp #5085
Conversation
30ac939
to
9ce82de
Compare
9ce82de
to
5d1d284
Compare
…tellar#4916) * Add batch insert builder which uses COPY to insert rows * Update support/db/fast_batch_insert_builder.go Co-authored-by: George <[email protected]> * Update fast_batch_insert_builder_test.go --------- Co-authored-by: George <[email protected]>
…s and claimable_balance_claimants tables
services/horizon/internal/db2/history: fix payments query (cherry picked from commit 4391e0b)
63eccb8
to
b797454
Compare
@urvisavla , per the branching strategy discussion, you intend to change merge target on this PR to ingestion-next? Wanted to let you know, I have two changes headed into the branch soon:
after which, if you then merge this PR to ingestion-next, we can then take the branch into some performance testing cycles to see how it's looking with all in, does this sound ok? |
Thanks @sreuland. Yes, as discussed, I am waiting for #5083 to be merged before I rebase and send this PR for review. I have started reviewing the #5083 and have a few questions that we can discuss tomorrow. Also, I can port the latest master to ingestion-next branch if you have not already started. |
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Use FastBatchInsertBuilder for writing to
claimable_balances
andclaimable_balance_claimants
tables. FastBatchInsertBuilder uses ‘COPY' to insert into the db which is faster than using 'INSERT'.Why
#5086
Known limitations