Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support/db: Add batch insert builder which uses COPY to insert rows #4916

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jun 16, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add batch insert builder which uses COPY to insert rows.

Why

This is required for #4908 which will allow us to populate rows in the history tables with COPY statements which have been shown to be significantly faster than INSERT statements.

Known limitations

[N/A]

@tamirms tamirms requested a review from Shaptic June 16, 2023 14:53
@Shaptic Shaptic changed the base branch from master to ingestion-next June 16, 2023 23:07
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing this to a feature branch, ingestion-next

@tamirms tamirms merged commit 9bc197d into stellar:ingestion-next Jul 5, 2023
@tamirms tamirms deleted the copy-batch branch July 5, 2023 08:47
urvisavla pushed a commit to urvisavla/go that referenced this pull request Oct 19, 2023
…tellar#4916)

* Add batch insert builder which uses COPY to insert rows

* Update support/db/fast_batch_insert_builder.go

Co-authored-by: George <[email protected]>

* Update fast_batch_insert_builder_test.go

---------

Co-authored-by: George <[email protected]>
urvisavla pushed a commit to urvisavla/go that referenced this pull request Oct 19, 2023
…tellar#4916)

* Add batch insert builder which uses COPY to insert rows

* Update support/db/fast_batch_insert_builder.go

Co-authored-by: George <[email protected]>

* Update fast_batch_insert_builder_test.go

---------

Co-authored-by: George <[email protected]>
urvisavla pushed a commit to urvisavla/go that referenced this pull request Oct 19, 2023
…tellar#4916)

* Add batch insert builder which uses COPY to insert rows

* Update support/db/fast_batch_insert_builder.go

Co-authored-by: George <[email protected]>

* Update fast_batch_insert_builder_test.go

---------

Co-authored-by: George <[email protected]>
urvisavla pushed a commit to urvisavla/go that referenced this pull request Oct 20, 2023
…tellar#4916)

* Add batch insert builder which uses COPY to insert rows

* Update support/db/fast_batch_insert_builder.go

Co-authored-by: George <[email protected]>

* Update fast_batch_insert_builder_test.go

---------

Co-authored-by: George <[email protected]>
urvisavla pushed a commit to urvisavla/go that referenced this pull request Oct 24, 2023
…tellar#4916)

* Add batch insert builder which uses COPY to insert rows

* Update support/db/fast_batch_insert_builder.go

Co-authored-by: George <[email protected]>

* Update fast_batch_insert_builder_test.go

---------

Co-authored-by: George <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants