Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/db2/history: Use FastBatchInsertBuilder to insert ledgers into the history_ledgers #4947

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jul 7, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

In #4916 we introduced a FastBatchInsertBuilder which can be used to quickly insert a large amount of rows into Postgres via the COPY command. In this PR, we use FastBatchInsertBuilder to insert ledgers into the history_ledgers table.

Why

As a part of #4908 , we want to update all the code which inserts data into the history tables to use the FastBatchInsertBuilder.

Known limitations

[N/A]

@tamirms tamirms requested a review from a team July 7, 2023 18:04
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 nice

just one design comment below ⬇️

}

// ledgerBatchInsertBuilder is a simple wrapper around db.BatchInsertBuilder
type ledgerBatchInsertBuilder struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost sounds like this could be generalized into a tableBatchInsertBuilder and reused?

Copy link
Contributor Author

@tamirms tamirms Jul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

db.FastBatchInsertBuilder is the component which could be used by multiple tables. ledgerBatchInsertBuilder has an Add() function which is specific to inserting ledgers. For other tables the Add() function would take different parameters

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sure, got it.

I think I was just thrown off by the fact that you have var table string as a separate variable that you explicitly assigned to "history_ledgers"; I'm seeing now that it's more of a quirk of not being able to assign in within the struct, e.g. how you can do something like

class ledgerBatchInsertBuilder {
  builder: db.FastBatchInsertBuilder;
  table: string = "history_ledgers";

  // constructors, etc...
}

in JS.

@Shaptic Shaptic requested review from sreuland and a team July 11, 2023 18:54
@tamirms tamirms merged commit b451d60 into stellar:ingestion-next Jul 11, 2023
@tamirms tamirms deleted the ledgers-batch branch July 11, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants