Merge master into amm branch #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit message of e011c91 was long enough to make `git log -1` command enable scrolling. This was causing `test_verify_range_docker_image` job failures because it got stuck at `git log -1` command waiting for user action. I also noticed that the Golang version in the image does not match the one we use in other places. I changed it to Go 1.17.
Golang time parser is not compatible with format rendered by the GNU date, even though both claim to be RFC3339. This change replaces space separator betwen date and time with "T" which will allow golang to parse it. It also switches from `--utc` to `-u` that's supported by both GNU and BSD date commands.
Format the VSCode tasks file. When I open the stellar/go repo locally in the latest version of VSCode it displays a warning saying the file is "dirty". It appears the file is not formatted to how VSCode prefers it to be formatted. I don't really know what this file does or is for, but supposedly it was added because somebody uses it. This change resolves the warning.
…tellar#3912) Using a generic `docker-compose down` command for stopping the Horizon integration test containers causes every docker-compose container to be brought down (including other containers, like the Horizon database container which can be started using docker-compose). This change makes sure we only destroy the containers brought up during integration testing.
Update docker image build timestamp format
This commit adds a new `UpsertOffers` method (and generic `upsertRows`) and modifies `OffersProcessor` to use it. The performance of `OffersProcessor` degraded recently due to number of offers in the network and batching updates should improve the performance of the processor and ingestion overall.
…iod-to-challenge-reader txnbuild: adds a 5 minute grace period to ReadChallengeTx MinTime constraint
* Run `apt-get` commands separately. Commands were previously joined by `&&` operator which returned 0 code in case any of the commands failure. * Hide hashes if they match. * Add unstable repo.
Add test coverage for the Hint functions of the keypair.FromAddress and keypair.Full types. Those functions aren't tested, and I'm iterating on the keypair code in stellar#3914 that involves changing the Hint functions, so I'd like test coverage present before hand.
Add tests to the crc16 package. We don't have any. I was digging around in the code for some thing else and wanted to make a change to the crc logic and make sure I don't break it.
Move the `crc16` package to `strkey/internal/crc16`. The `crc16` package implements a single form of crc16, the form specifically used by [strkeys](https://stellar.org/protocol/sep-23). It is only used by the `strkey` package and it is not really something that needs to be exported for others to use in other contexts. The `crc16` package is not officially released in any particular package.
…nter to summary (stellar#3940) Add a new metric `ProcessorsRunDurationSummary`/`processor_run_duration_seconds` to replace existing `ProcessorsRunDuration`(`processor_run_duration_seconds_total`. The old metric is now deprecated. The `ProcessorsRunDuration` is a counter. While it allows estimating and comparing actual duration of processors it's impossible to calculate average per ledger run duration because number of events are not counted.
2opremio
force-pushed
the
merge-master
branch
from
4293a7d to
bec53dd
Compare
bartekn
approved these changes
Sep 20, 2021
2opremio
force-pushed
the
merge-master
branch
from
bec53dd to
2aac2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this for #3931