Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crc16: add tests #3924

Merged
merged 7 commits into from
Sep 16, 2021
Merged

crc16: add tests #3924

merged 7 commits into from
Sep 16, 2021

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Sep 16, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add tests to the crc16 package.

Why

We don't have any. I was digging around in the code for some thing else and wanted to make a change to the crc logic and make sure I don't break it.

Known limitations

N/A

@leighmcculloch leighmcculloch requested a review from a team September 16, 2021 00:02
@leighmcculloch leighmcculloch requested a review from a team September 16, 2021 00:40
go.list Outdated Show resolved Hide resolved
@leighmcculloch
Copy link
Member Author

Dependencies upgraded:

Copy link
Contributor

@acharb acharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@leighmcculloch leighmcculloch merged commit 2b12232 into stellar:master Sep 16, 2021
@leighmcculloch leighmcculloch deleted the crc16-test branch September 16, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants