-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon: Change ingest/ledgerbackend/LedgerBackend.GetLedger to be always blocking #3576
Merged
paulbellamy
merged 12 commits into
stellar:master
from
paulbellamy:3549/blocking-get-ledger
May 4, 2021
Merged
services/horizon: Change ingest/ledgerbackend/LedgerBackend.GetLedger to be always blocking #3576
paulbellamy
merged 12 commits into
stellar:master
from
paulbellamy:3549/blocking-get-ledger
May 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbellamy
force-pushed
the
3549/blocking-get-ledger
branch
from
April 29, 2021 16:24
333fb00
to
f70e7dc
Compare
tamirms
reviewed
May 2, 2021
tamirms
reviewed
May 2, 2021
paulbellamy
force-pushed
the
3549/blocking-get-ledger
branch
from
May 3, 2021 14:58
43a1fd8
to
5011ad3
Compare
tamirms
reviewed
May 3, 2021
tamirms
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
context.Context
as first param to most LedgerBackend methods, so that blocking ones can be aborted early due to shutdown or request timeout.ingest/ledgerbackend/LedgerBackend.GetLedgerBlocking
.ingest/ledgerbackend/LedgerBackend.GetLedger
to always be blocking.408 Request Timeout
) toexp/services/captivecore/internal/server.go
's/ledger/{sequence}
, so thatingest/ledgerbackend/RemoteCaptiveCore.GetLedger
, can retry and long-poll until the requested ledger is ready.Why
Known limitations
exp/services/captivecore/internal/client.go
into theingest/ledgerbackend/CaptiveCoreBackend
itself, to ensure we always expose the same constraints.