-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon: Build and test verify-range Docker image #3575
services/horizon: Build and test verify-range Docker image #3575
Conversation
2f1a872
to
f504c18
Compare
.circleci/config.yml
Outdated
name: Build and test Verify Range Docker image | ||
command: | | ||
docker build -f services/horizon/docker/verify-range/Dockerfile -t stellar/horizon-verify-range services/horizon/docker/verify-range/ | ||
docker run -ti -e BRANCH=master -e FROM=15000063 -e TO=15000127 stellar/horizon-verify-range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there is a better range to test, but I didn't want it to take more than a few minutes.
@bartekn let me know if you have other range suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's other ranges to test, we could do a few different ranges in parallel on circle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it would be nice to comment in the circle file why we chose these particular ranges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to have a single range here. Isn't it added here just to check if the image works? I have some ideas when it comes to ranges but the image is run using the code from master
so it wouldn't really test the PR.
.circleci/config.yml
Outdated
name: Build and test Verify Range Docker image | ||
command: | | ||
docker build -f services/horizon/docker/verify-range/Dockerfile -t stellar/horizon-verify-range services/horizon/docker/verify-range/ | ||
docker run -ti -e BRANCH=master -e FROM=15000063 -e TO=15000127 stellar/horizon-verify-range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to have a single range here. Isn't it added here just to check if the image works? I have some ideas when it comes to ranges but the image is run using the code from master
so it wouldn't really test the PR.
74e973f
to
005838d
Compare
Uhm, I rebased and the verify-range test gets stuck, I suspect it could be due to #3576 I will remove the PR and see if it passes |
806f284
to
5702220
Compare
I think it is due to #3576 (it works with |
5b5ba31
to
bcfbc7f
Compare
OK, it seems to randomly get stuck (it just worked with master). |
I am thinking it may be a memory problem, so I am going to move to an even earlier range. |
Part of #2761