services/horizon: Remove global ledger state #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
force-pushed
the
ledger-state
branch
4 times, most recently
from
2e5ee7f to
05db866
Compare
tamirms
force-pushed
the
ledger-state
branch
from
3f6fd5c to
d55645d
Compare
bartekn
approved these changes
Nov 12, 2020
Comment on lines
+20
to
26
| pq, err := GetPageQuery(handler.LedgerState, r) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| err = validateCursorWithinHistory(pq) | ||
| err = validateCursorWithinHistory(handler.LedgerState, pq) | ||
| if err != nil { |
There was a problem hiding this comment.
I don't think it's an issue now but it's possible that LedgerState will change between the first and second call to CurrentState(). It can be safer to read the state once and pass it to the functions that need it.
In the future, when #2674 is done, we can pass the actual state to the handler so it's not possible to misuse it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #3195