Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon/ledger.State package in Horizon is a global variable #3195

Closed
bartekn opened this issue Nov 5, 2020 · 0 comments · Fixed by #3216
Closed

services/horizon/ledger.State package in Horizon is a global variable #3195

bartekn opened this issue Nov 5, 2020 · 0 comments · Fixed by #3216
Labels
bug horizon

Comments

@bartekn
Copy link
Contributor

bartekn commented Nov 5, 2020

horizon/ledger.State is a global variable. This is a bad pattern and caused some issues (see #3143). We should make the state local to horizon.App and pass a pointer to it to other parts of the system that need it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug horizon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

services/horizon: Remove global ledger state tamirms/go
1 participant
@bartekn