Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Check state rebuild in state verification integration test #3102

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Oct 6, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Check state rebuild in state verification integration test.

Why

All integration tests start from empty state so we don't test building state from history archives. Extended state verification integration test to trigger state rebuild (horizon expingest trigger-state-rebuild) and verify rebuild state again. Such test would catch the bugs like #3100 and #3096.

Known limitations

It will make the test 3x slower so let's merge it after moving integration tests to nightly runs.

@bartekn bartekn requested a review from a team October 6, 2020 22:23
@cla-bot cla-bot bot added the cla: yes label Oct 6, 2020
@bartekn bartekn closed this Oct 14, 2020
@bartekn
Copy link
Contributor Author

bartekn commented Oct 14, 2020

Damn, closed because I removed a release branch. Going to create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants