services/horizon: Insert signers's sponsorship information during state ingestion #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
approved these changes
Oct 5, 2020
This was referenced Oct 7, 2020
bartekn
added a commit
that referenced
this pull request
Oct 28, 2020
…on test (#3127) All integration tests start from empty state so we don't test building state from history archives. Extended state verification integration test to trigger state rebuild (`horizon expingest trigger-state-rebuild`) and verify rebuild state again. Such test would catch the bugs like #3100 and #3096.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fixes
SignersProcessorto insert sponsorship information during state ingestion from history archives.Why
SignersProcessoroperates in two modes:useLedgerEntryCacheset totrueorfalse. When ingesting history archives we useuseLedgerEntryCache=falseto save memory - ledger entry cache is not needed because there are only inserts. This code path was not updated to include information about the sponsor of a signer.Known limitations
If we decide to release it in 1.9.1 we should update CHANGELOG.