Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdr: Use underscore in JSON fields for claim predicate. #3086

Merged

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Oct 1, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Use underscore in JSON fields for claim predicate.

Why

Horizon uses underscore for payload fields, this change updates JSON marshaling to use underscore.

Fixes #3079

Known limitations

[TODO or N/A]

@cla-bot cla-bot bot added the cla: yes label Oct 1, 2020
@abuiles abuiles force-pushed the sneak-case-claim-predicate branch from b8dc48a to 764d8eb Compare October 1, 2020 20:57
@abuiles abuiles changed the base branch from master to release-horizon-v1.10.0 October 1, 2020 22:13
@@ -42,7 +42,8 @@ const (
// - 10: Fixes a bug in meta processing (fees are now processed before
// everything else).
// - 11: Protocol 14: CAP-23 and CAP-33.
CurrentVersion = 11
// - 12: Update claim predicate JSON fields to use underscore instead of camel case.
CurrentVersion = 12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do this. We can manually rebuild state with horizon expingest trigger-state-rebuild.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were right, this is better for end users: #3100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming predicate JSON fields to snake case
2 participants