Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming predicate JSON fields to snake case #3079

Closed
bartekn opened this issue Sep 30, 2020 · 1 comment · Fixed by #3086
Closed

Consider renaming predicate JSON fields to snake case #3079

bartekn opened this issue Sep 30, 2020 · 1 comment · Fixed by #3086

Comments

@bartekn
Copy link
Contributor

bartekn commented Sep 30, 2020

What version are you using?

1.9.0

What did you do?

Request claimable balance created by @abuiles: https://horizon-testnet.stellar.org/claimable_balances/0000000043d380c38a2f2cac46ab63674064c56fdce6b977fdef1a278ad50e1a7e6a5e18:

    {
      "destination": "GB6QDNU47MYBR4NDTRP7M3FW27DAFOEADN5KDQI2DAVWW6YVKKG4QJS7",
      "predicate": {
        "and": [
          {
            "not": {
              "absBefore": "2020-09-30T16:19:04Z"
            }
          },
          {
            "or": [
              {
                "absBefore": "2020-09-30T16:34:04Z"
              },
              {
                "not": {
                  "absBefore": "2020-10-01T22:17:24Z"
                }
              }
            ]
          }
        ]
      }
    }

What did you expect to see?

abs_before - snake case name consistent with other fields.

What did you see instead?

absBefore - camel case.

@abuiles
Copy link
Contributor

abuiles commented Oct 2, 2020

Fixed in #3086

@abuiles abuiles closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants