services/horizon: Remove ingest failed transactions flag #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
changed the title
tamirms
force-pushed
the
always-ingest-failed-tx
branch
5 times, most recently
from
ff468ef to
4a2b798
Compare
abuiles
reviewed
Jun 17, 2020
tamirms
force-pushed
the
always-ingest-failed-tx
branch
from
4a2b798 to
34c1541
Compare
tamirms
force-pushed
the
always-ingest-failed-tx
branch
from
b31dc86 to
0aa3e6a
Compare
3 tasks
bartekn
approved these changes
Jun 17, 2020
Co-authored-by: Bartek Nowotarski <[email protected]>
abuiles
approved these changes
Jun 17, 2020
| } | ||
|
|
||
| var _ txsub.ResultProvider = &DB{} | ||
|
|
||
| // ResultByHash implements txsub.ResultProvider | ||
| func (rp *DB) ResultByHash(ctx context.Context, hash string) txsub.Result { | ||
| historyLatest := ledger.CurrentState().HistoryLatest | ||
|
|
||
| // query history database | ||
| var hr history.Transaction | ||
| err := rp.History.TransactionByHash(&hr, hash) |
There was a problem hiding this comment.
@tamirms do we allow tx submission if Horizon is catching up with stellar-core? could this potentially cause a hash not to be found (since it hasn't been ingested)?
There was a problem hiding this comment.
that's a good point. I think this issue you've spotted was already there before this PR so we can try to tackle it in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Remove ingest failed transactions flag so that Horizon will always ingest failed transactions
Why
Having failed transactions in the Horizon DB is useful because it allows us to remove the last remaining dependency on the stellar core DB in the txsub module.
Known limitations
There might be some operators who prefer to save space by not ingesting failed transactions in the Horizon DB. However, there is a reap system in Horizon which allows you to remove older rows in the history tables. Using horizon reap should satisfy the same need.