Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all instances of code that access core db #2643

Closed
3 tasks done
abuiles opened this issue Jun 1, 2020 · 3 comments
Closed
3 tasks done

Remove all instances of code that access core db #2643

abuiles opened this issue Jun 1, 2020 · 3 comments
Assignees
@abuiles
Labels
blocked blocked by another issue fast-txmeta
Milestone
Horizon 1.5.0

Comments

@abuiles
Copy link
Contributor

abuiles commented Jun 1, 2020 •
edited
Loading

We should remove Core DB access where possible. Ideally, Horizon shouldn't rely on Core DB to work correctly.

TODO

The following are a list of places where we still using core's db which we won't be able to drop yet.
@bartekn
Copy link
Contributor

bartekn commented Jun 3, 2020

I think that ultimately we should remove all Core DB access before shipping captive core. Simply remove db2/core package and see what happens.

@bartekn bartekn changed the title Use horizon db instead of core db to load AssetsForAddress. Remove all instances of code that access core db Jun 3, 2020
@abuiles abuiles self-assigned this Jun 3, 2020
@bartekn bartekn added this to the Horizon 1.5.0 milestone Jun 4, 2020
This was referenced Jun 4, 2020
Merged
Merged
abuiles added a commit that referenced this issue Jun 4, 2020
@abuiles
services/horizon/internal/simplepath: Remove DB path finder. (#2663)
27bf500 
### What

Drop DB based path finder. 

### Why

We have replaced the DB based implementation in favor of the `inmemory` implementation so we not longer need this code. 

This is part of the work to drop `db2/core` (#2643).
This was referenced Jun 5, 2020
Merged
Merged
abuiles added a commit that referenced this issue Jun 8, 2020
@abuiles
services/horizon/interal/actions: Drop db2/core dependency in path fi…
954ddeb 
…nding actions. (#2675)

- Drop `db2/core` dependency on path finding actions.
- Simplify tests for path finding, removing dependency on pre-built scenario.
- Add mock for `paths.Finder`

### Why

We are in the process of removing Horizon's dependency on `core`'s db. This PR removes such dependency on the path finding end-points and changes the tests to not depend on pre-built SQL scenarios.

This is part of the work to drop `db2/core` (#2643).
abuiles added a commit that referenced this issue Jun 8, 2020
@abuiles
services/horizon: Remove Core DB access from web, actions, and resour…
e08171f 
…ceadapters. (#2677)

Remove Core DB access from `web`, `actions`, and `resourceadapters`.

## Why
This is part of the work to drop db2/core (#2643).
@abuiles abuiles added the blocked blocked by another issue label Jun 8, 2020
@abuiles
Copy link
Contributor Author

abuiles commented Jun 22, 2020

I just added the following ticket to keep track of the other task to get this done #2725

@abuiles
Copy link
Contributor Author

abuiles commented Jun 23, 2020

This has been fixed now.

@abuiles abuiles closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuiles abuiles

Labels
blocked blocked by another issue fast-txmeta
Projects
None yet
Milestone
Horizon 1.5.0
Development

No branches or pull requests
2 participants
@abuiles @bartekn