services/horizon/internal: Create separate db connections for ingestion #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
reviewed
May 7, 2020
|
We can probably merge it into |
bartekn
approved these changes
May 8, 2020
services/horizon/internal/init.go
Outdated
| @@ -19,33 +19,70 @@ import ( | |||
| "github.com/stellar/go/support/log" | |||
| ) | |||
|
|
|||
| func mustInitHorizonDB(app *App) { | |||
| session, err := db.Open("postgres", app.config.DatabaseURL) | |||
| const maxIngestionDBConnections = 2 | |||
There was a problem hiding this comment.
I think it belongs to the ingest package. Say, we add a new routine that require an extra DB connection. Would be easier to increment it there.
services/horizon/internal/init.go
Outdated
| // and another pool for ingestion. Ideally the total connections in both | ||
| // pools should be bounded by HorizonDBMaxOpenConnections. But, if the ingestion | ||
| // pool consumes a significant quota of HorizonDBMaxOpenConnections then we will | ||
| // allow a total of HorizonDBMaxOpenConnections + maxIngestionDBConnections connections. |
There was a problem hiding this comment.
I think we should just return an error (maybe at a command validation stage in root.go) when ingestion connections is equal/greater than max set by a user. The reason is that user may explicitly set the max number of open connections in Postgres config so these extra 2 connections won't be established (and will probably generate a bunch of errors in the log).
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fixes #2018
Create separate db connections to the horizon and stellar core databases for ingestion.
Why
Known limitations
[N/A]