Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/expingest: Separate DB connection pool for ingestion service #2018

Closed
bartekn opened this issue Dec 6, 2019 · 2 comments · Fixed by #2560
Closed

services/horizon/expingest: Separate DB connection pool for ingestion service #2018

bartekn opened this issue Dec 6, 2019 · 2 comments · Fixed by #2560
Labels
Milestone

Comments

@bartekn
Copy link
Contributor

bartekn commented Dec 6, 2019

Currently, all of the Horizon services share the same DB connection pool. In case of increased number of HTTP requests, it's possible that ingestion service will have to wait for an idle connection. We need to create a separate connection pool (with a number of open connections equal to [horizon max] - [max needed by ingestion at any given time: 2 right now?]) for ingestion service to make sure it can always proceed.

@bartekn bartekn added the horizon label Dec 6, 2019
@bartekn bartekn added this to the Horizon 0.25.0 milestone Dec 6, 2019
@ire-and-curses ire-and-curses removed this from the Horizon 1.0.1 milestone Mar 17, 2020
@ire-and-curses
Copy link
Member

Now that we have split ingesting and front-facing nodes, this isn't necessary for our cluster. It could still potentially be helpful for single machine deployments. Let's revisit if that seems to be the case.

@bartekn
Copy link
Contributor Author

bartekn commented May 7, 2020

Reopening. Frontend nodes still run ingestion because they ingest offers into in-memory order book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants