protocols/horizon: Change JSON response from int64 to string in multiple places. #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
changed the title
abuiles
force-pushed
the
deprecate-fee-stats-data
branch
from
39df62a to
86e6564
Compare
abuiles
changed the base branch from
deprecate-fee-stats-data
to
release-horizon-v0.25.0
abuiles
force-pushed
the
int64-string
branch
2 times, most recently
from
041617b to
bd38a6c
Compare
abuiles
commented
Jan 16, 2020
| @@ -261,6 +261,21 @@ type Effect struct { | |||
| DetailsString null.String `db:"details"` | |||
| } | |||
|
|
|||
| // TradeEffectDetails is a struct of data from `effects.DetailsString` | |||
| // when the effect type is trade | |||
| type TradeEffectDetails struct { | |||
There was a problem hiding this comment.
The representation for a trade effect at at db level is slightly different than the representation at the resource level. Specifically, OfferID is stored in the db as an int64.
tamirms
approved these changes
Jan 20, 2020
bartekn
approved these changes
Jan 20, 2020
Change the type for multiple JSON fields using `int64` to be of type `string`: - Attribute `offer_id` in [manage buy offer](https://www.stellar.org/developers/horizon/reference/resources/operation.html#manage-buy-offer) and [manage sell offer](https://www.stellar.org/developers/horizon/reference/resources/operation.html#manage-sell-offer) operations. - Attribute `offer_id` in [Trade](https://www.stellar.org/developers/horizon/reference/resources/effect.html#trading-effects) effect. - Attribute `id` in [Offer](https://www.stellar.org/developers/horizon/reference/resources/offer.html) resource. - Attribute `timestamp` and `trade_count` in [Trade Aggregation](https://www.stellar.org/developers/horizon/reference/resources/trade_aggregation.html) resource. - Attribute `new_seq` in [Sequence Bumpeed](https://www.stellar.org/developers/horizon/reference/resources/effect.html#misc-effects) effect.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Change the type for multiple JSON fields using
int64to be of typestring:offer_idin manage buy offer and manage sell offer operations.offer_idin Trade effect.idin Offer resource.timestampandtrade_countin Trade Aggregation resource.new_seqin Sequence Bumpeed effect.Why
As discussed in the following issues: #1609, #1363 -- we should be using string for int64 values since it leads to data getting lost when using JS.
Known limitations
TODO
Update branch once fee deprecation has been merge in 0.25.0 release