-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide on use of int64 in JSON responses. #1609
Comments
@abuiles can you update the Horizon 0.20.0 CHANGELOG with this list and add |
Because of our imminent special v12 protocol release (Horizon 0.22), these fields are now scheduled to change in 0.23. |
After internal discussion we're going to change all of these in Horizon 0.25, to give SDKs enough time to handle it. |
Has a decision been made on this yet? I don't see a decision communicated here, but |
Yes. These fields will change to |
Fixed on #2021 |
This is a follow up of #1363 - we have multiple places where we return int64 in JSON responses, which could lead to issues in JS applications. We fixed the problem reported in #1363, but the question now is, should we do the same for the following struct and moving forward, does it make sense to avoid int64 on Horizon structs? We haven't been consistent with this.
json:"offer_id"
json:"offer_id"
json:"offer_id"
json:"id"
json:"timestamp"
json:"trade_count"
The text was updated successfully, but these errors were encountered: