-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizon v1.0.0 Compatibility #478
Comments
WIP #477 |
This needs to be done in js-stellar-base |
Meta V2 support coming through js-base https://github.com/stellar/js-stellar-base/pull/288/files |
We are missing support for |
This was fixed and it's available in 4.0.0 |
The upcoming Horizon release (1.0 BETA) is coming, and there are multiple breaking changes plus new features 🎉🎉🎉!
The following are the list of changes required to support this new release:
➕Update
/fee_stats
response.✂ Remove the following fields:
➕Add support for
max_fee
andfee_charged
fields. Each field contains a JSON object that looks like this:See Update /fee_stats documentation. go#2140 for more info.
✂ Remove deprecated
fee_paid
field from Transaction response (replace it with thefee_charged
andmax_fee
fields).🚨Multiple fields changed from
int64
tostring
. If your SDK has types, they need to be updated. If possible, we recommend implementing backward compatibility support, as we did here.Attribute
offer_id
in manage buy offer and manage sell offer operations.Attribute
offer_id
inTrade
effect.Attribute
id
in Offer resource.Attribute
timestamp
andtrade_count
in Trade Aggregation resource.See Decide on use of int64 in JSON responses. go#1609, protocols/horizon/effects: Add UnmarshalJSON to SequenceBumped. go#1909, and Support String or Number Unmarshalling in Int64 fields go#1912 for more info
🚨 Update operation types to canonical names (if needed) (see protocols/horizon: Apply deprecation on some operation types, updating them to the correct value go#2134).
➕Add support for
/accounts
end-point with?signer
and?asset
filters. We recommend a method like.accounts(queryParams)
(see documentation for accounts).➕Add support for
/offers
end-point with query parameters. We recommend a method like.offers(queryParams)
(see documentation for offers).➕Add support for
/paths/strict-send
end-point. See documentation.We recommend a method like
➕ Add support for
/paths/strict-receive
end-point. See documentation.We recommend a method like:
♻ Regenerate the XDR definitions to include MetaV2 support (also see #1902).
That's it! If you have any questions feel free to ping us on #dev-discussion in Keybase.
The text was updated successfully, but these errors were encountered: