Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action that checks git rev deps for orphan likeliness #56

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Aug 29, 2023

What

Add action that checks git rev deps for whether they are likely to be orphaned.

Why

On a number of occassions we've accidentally committed a reference to a dependency that belongs to a commit on a pull request. The pull request was then closed, and while the commit lives forever in the Git repository, it is not seen by tools that do not fetch orphaned commits.

Close #55

@leighmcculloch leighmcculloch requested a review from graydon August 29, 2023 23:16
@leighmcculloch leighmcculloch marked this pull request as ready for review August 29, 2023 23:57
@leighmcculloch leighmcculloch enabled auto-merge (squash) August 29, 2023 23:57
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@leighmcculloch leighmcculloch merged commit 912d7c3 into main Aug 30, 2023
@leighmcculloch leighmcculloch deleted the i55 branch August 30, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action that verifies Rust git dependency commits will not be orphaned
2 participants