Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action that verifies Rust git dependency commits will not be orphaned #55

Closed
leighmcculloch opened this issue Aug 29, 2023 · 0 comments · Fixed by #56, stellar/rs-soroban-env#1025 or stellar/rs-soroban-sdk#1078
Assignees

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Aug 29, 2023

What

Add action that checks git rev deps for whether they are likely to be orphaned.

Why

On a number of occassions we've accidentally committed a reference to a dependency that belongs to a commit on a pull request. The pull request was then closed, and while the commit lives forever in the Git repository, it is not seen by tools that do not fetch orphaned commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant