Test coverage for Gateways Controllers

app/scripts/services/gateways-service.js

@@ -47,6 +47,7 @@ sc.service('Gateways', function($q, $analytics, session, StellarNetwork, rpStell
 
   Gateways.remove = function(gateway) {
     gateway.status = "removing";
+    walletGateways()[gateway.domain].status = "removing";
     return Gateways.syncTrustlines(gateway.domain).then(function() {
       if(!_.has(walletGateways(), gateway.domain)) {
         track(gateway, 'Gateway Removed');

test/unit/karma.conf.js

@@ -59,16 +59,26 @@ module.exports = function(config) {
     'app/scripts/**/*.js',
 
     //test-only mocks
-    'test/unit/mocks/service-mocks.js',
+    'test/unit/mocks/gateway-mocks.js',
+    'test/unit/mocks/session-mocks.js',
+    'test/unit/mocks/stellar-network-mocks.js',
 
     //specs
-    'test/unit/specs/controllers/add-email-controller-test.js'
+    'test/unit/specs/controllers/add-email-controller-test.js',
+
+    //gateways
+    'test/unit/specs/controllers/add-gateway-controller-test.js',
+    'test/unit/specs/controllers/gateway-list-controller-test.js',
+    'test/unit/specs/controllers/gateway-list-item-controller-test.js'
 
     ],
 
 
     // list of files / patterns to exclude
-    exclude: ['app/bower_components/URIjs/**/**.js',],//couldn't get this URI to work server side
+    exclude: [
+    'app/bower_components/URIjs/**/**.js',//couldn't get this URI to work server side
+    'app/scripts/libraries/underscore.js'//Why do we have underscore in there? 
+    ],
 
     // web server port
     port: 8080,

test/unit/mocks/gateway-mocks.js

@@ -0,0 +1,25 @@
+'use strict';
+
+angular.module('mockGateway', [])
+  .factory('Gateways', ['$q', function($q) {
+    var gateway = {
+      search: function (domain) {
+        var found = {
+          domain: domain,
+          currencies: ['usd', 'cny']
+        };
+        var deferred = $q.defer();
+        setTimeout(function() {
+          if (domain === 'failing-gateway') {
+            deferred.reject(found);
+          }
+          else {
+             deferred.resolve(found);
+          };
+        }, 10);
+        return deferred.promise;
+      }, 
+    };
+    return gateway
+  }]);
+

test/unit/mocks/session-mocks.js

@@ -0,0 +1,24 @@
+'use strict';
+
+angular.module('mockSession', [])
+  .factory('session', [function() {
+    var session_data = {
+      keychainData : {
+        updateToken: true
+      }, 
+      mainData: {
+        email: '', 
+        gateways: {
+          'test-gateway': {
+            domain: 'test-gateway', 
+            currencies: ['usd', 'cny']
+          },
+          'removing-gateway': {
+            domain: 'removing-gateway', 
+            currencies: ['usd', 'cny'],
+          }
+        }
+      }
+    };
+    return {get: function () {return session_data}, syncWallet: function () {}}
+  }]);

test/unit/mocks/stellar-network-mocks.js

@@ -0,0 +1,21 @@
+'use strict';
+
+angular.module('mockStellarNetwork', [])
+  .factory('StellarNetwork', [function() {
+    var transaction = {
+      trustSet: function () {},
+      setFlags: function () {},
+      submit:   function () {},
+      on:       function (event, callback) {
+        if (event === 'success'){
+          callback('ok')
+        };
+      }
+    }
+    var network = {
+      remote: {
+        transaction: function () {return transaction}
+      }
+    };
+    return network
+  }]);

test/unit/specs/controllers/add-email-controller-test.js

@@ -4,8 +4,10 @@ describe('Controller: AddEmailCtrl', function () {
 
   // load the controller's module
   beforeEach(module('stellarClient'));
+
   //load the mocks for services
-  beforeEach(module('serviceMocks'));
+  beforeEach(module('mockSession'));
+  beforeEach(module('mockGateway'));
 
 
   var AddEmailCtrl, scope, mockBackend;

test/unit/specs/controllers/add-gateway-controller-test.js

@@ -0,0 +1,61 @@
+'use strict';
+
+describe('Controller: AddGatewayCtrl, mocking out search', function () {
+
+  // load the controller's module
+  beforeEach(module('stellarClient'));
+
+  //load the mocks for services
+  beforeEach(module('mockSession'));
+  beforeEach(module('mockGateway'));
+
+  var AddGatewayCtrl, scope;
+
+  // Initialize the controller and a mock scope
+  beforeEach(inject(function ($controller, $rootScope) {
+    scope = $rootScope.$new();
+    AddGatewayCtrl = $controller('AddGatewayCtrl', {
+      $scope: scope
+    });
+  }));
+
+  it('Initially, the search params should always be reset', function () {
+    expect(scope.gatewaySearch).to.equal('');
+    expect(scope.searchStatus).to.equal('');
+    expect(scope.foundGateway).to.equal(null);
+    expect(scope.fromActionLink).to.equal(false);
+  });
+
+  it('If an empty search is triggered, nothing should happen', function () {
+    expect(scope.gatewaySearch).to.equal('');
+    scope.loadCurrencies();
+    expect(scope.foundGateway).to.equal(null);
+  });
+
+  it('When searching for a gateway that had already been added, the searchStatus should reflect that', function () {
+    scope.gateways = {'test-gateway': true};
+    scope.gatewaySearch = 'test-gateway'
+    scope.loadCurrencies();
+    expect(scope.searchStatus).to.equal('already_added');
+  });
+
+  it('If a gateway is found, the result should be added to foundGateway', function () {
+    scope.gateways = {};
+    scope.gatewaySearch = 'test-gateway'
+    var promise = scope.loadCurrencies();
+    promise.then(function (){
+      expect(scope.foundGateway).to.equal({domain: 'test gateway', curencies: ['usd', 'cny']});
+      expect(scope.searchStatus).to.equal('found');
+    });
+  });
+
+  it('If no gateway is found, the search status should resolve to not_found', function () {
+    scope.gateways = {};
+    scope.gatewaySearch = 'failing-gateway'
+    var promise = scope.loadCurrencies();
+    promise.then(function (){
+      expect(scope.foundGateway).to.equal(null);
+      expect(scope.searchStatus).to.equal('not_found');
+    });
+  });
+});

test/unit/specs/controllers/gateway-list-controller-test.js

@@ -0,0 +1,32 @@
+'use strict';
+
+describe('Controller: GatewayListCtrl', function () {
+
+  // load the controller's module
+  beforeEach(module('stellarClient'));
+
+  //load the mocks for services
+  beforeEach(module('mockSession'));
+  beforeEach(module('mockGateway'));
+
+  var GatewayListCtrl, scope;
+
+  // Initialize the controller and a mock scope
+  beforeEach(inject(function ($controller, $rootScope) {
+    scope = $rootScope.$new();
+    GatewayListCtrl = $controller('GatewayListCtrl', {
+      $scope: scope
+    });
+  }));
+
+  it('If there are any gateways, hasGateways should resolve to true', function () {
+    scope.gateways = ['one_gateway', 'two_gateway']
+    expect(scope.hasGateways()).to.equal(true);
+  });
+
+  it("If there aren't any gateways, hasGateways should resolve to false", function () {
+    scope.gateways = []
+    expect(scope.hasGateways()).to.equal(false);
+  });
+
+});

test/unit/specs/controllers/gateway-list-item-controller-test.js

@@ -0,0 +1,61 @@
+'use strict';
+
+describe('Controller: GatewayListItemCtrl', function () {
+
+  // load the controller's module
+  beforeEach(module('stellarClient'));
+
+  //load the mocks for services
+  beforeEach(module('mockSession'));
+  beforeEach(module('mockStellarNetwork'));
+
+  var GatewayListItemCtrl, scope, rootScope, inner_session;
+
+  // Initialize the controller and a mock scope
+  beforeEach(inject(function ($controller, $rootScope, session) {
+    rootScope = $rootScope;
+    inner_session = session;
+    scope = $rootScope.$new();
+    GatewayListItemCtrl = $controller('GatewayListItemCtrl', {
+      $scope: scope
+    });
+  }));
+
+  it('You should be able to remove the current gateway', function () {
+    scope.gateway =  {
+            domain: 'removing-gateway', 
+            currencies: ['usd', 'cny'],
+          };
+    expect(inner_session.get().mainData.gateways['removing-gateway'].domain).to.equal(scope.gateway.domain);
+    scope.remove();
+    expect(scope.gateway.status).to.equal('removing')
+    expect(inner_session.get().mainData.gateways['removing-gateway'].status).to.equal('removing');
+    rootScope.$apply();
+    expect(inner_session.get().mainData.gateways['removing-gateway']).to.equal(undefined);
+    //note we're not actually removing the gateway from the scope, we're only removing it from the session
+    expect(scope.gateway.status).to.equal('removing')
+  });
+
+  it('You should be able to retry adding a gateway', function () {
+    scope.gateway = {
+            domain: 'new-gateway', 
+            currencies: ['usd', 'cny'],
+          };
+    expect(inner_session.get().mainData.gateways['new-gateway']).to.equal(undefined);
+    scope.retryAdd();
+    expect(inner_session.get().mainData.gateways['new-gateway'].status).to.equal('adding');
+    rootScope.$apply();
+    expect(inner_session.get().mainData.gateways['new-gateway'].status).to.equal('added');
+  });
+
+  it('You should be able to cancel adding a gateway', function () {
+    scope.gateway = {
+            domain: 'test-gateway', 
+            currencies: ['usd', 'cny']
+          };
+    expect(inner_session.get().mainData.gateways['test-gateway']).to.exists;
+    scope.cancelAdd();
+    expect(inner_session.get().mainData.gateways['test-gateway']).to.be.undefined;
+  });
+
+});