This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Test coverage for Gateways Controllers #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,7 @@ sc.service('Gateways', function($q, $analytics, session, StellarNetwork, rpStell | |||
|
|
|||
| Gateways.remove = function(gateway) { | |||
| gateway.status = "removing"; | |||
| walletGateways()[gateway.domain].status = "removing"; | |||
There was a problem hiding this comment.
this just matches what goes on in the 'add' method. Without this the tests would not pass (unless I would beforehand set the status of the gateway in the mocked out session to 'removing')
|
@nullstyle Ok this one is good to go on my side. Just made one little change to the |
|
👍 |
nullstyle
added a commit
that referenced
this pull request
Mar 2, 2015
Test coverage for Gateways Controllers
|
@gterzian thanks! |
|
Whoops, yeah I forgot to send thanks. Thanks @gterzian! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
I'll also try to write a failing test for #1166 (and perhaps point to a fix)