This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Add AUTH_REQUIRED section #308
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,7 +83,7 @@ contract). | |
the issuer account will mint. | ||
- Trustline balances are stored in a 64-bit signed integer even though the | ||
interface accepts 128-bit signed integers. Any operation that attempts to | ||
send or recieve an amount more than the maximum amount that can be | ||
send or receive an amount more than the maximum amount that can be | ||
represented by a 64-bit signed integer will fail. | ||
- Using `Address::Contract` | ||
- The balance and authorization state will be stored in contract storage, as | ||
|
@@ -92,6 +92,13 @@ contract). | |
balance. | ||
- Balances are stored in a 128-bit signed integer. | ||
|
||
### Authorization Required | ||
In the `Address::Contract` case, if the issuer has `AUTH_REQUIRED` set, then the | ||
specified `Address::Contract` will need to be explicitly authorized before it | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add the respective function name here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
can receive a balance. This logic lines up with how trustlines interact with the | ||
`AUTH_REQUIRED` issuer flag, allowing asset issuers to have the same control in | ||
Soroban as they do in Stellar classic. | ||
|
||
## Authorization semantics | ||
|
||
See the [authorization overview](../learn/authorization.mdx) and | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some reference to the classic docs about this? I'm a bit worried about the name collisions and confusion with Soroban auth. Maybe also name this something like 'Balance Authorization' or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I linked to the classic docs, but I need to open a PR against them because naming isn't consistent there. For example, the docs reference both
AUTH_REQUIRED_FLAG
andAUTHORIZATION_REQUIRED