Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add AUTH_REQUIRED section #308

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

sisuresh
Copy link
Contributor

No description provided.

@sisuresh sisuresh requested a review from dmkozh February 13, 2023 17:22
@stellar-jenkins
Copy link

@@ -92,6 +92,13 @@ contract).
balance.
- Balances are stored in a 128-bit signed integer.

### Authorization Required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some reference to the classic docs about this? I'm a bit worried about the name collisions and confusion with Soroban auth. Maybe also name this something like 'Balance Authorization' or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked to the classic docs, but I need to open a PR against them because naming isn't consistent there. For example, the docs reference both AUTH_REQUIRED_FLAG and AUTHORIZATION_REQUIRED

@@ -92,6 +92,13 @@ contract).
balance.
- Balances are stored in a 128-bit signed integer.

### Authorization Required
In the `Address::Contract` case, if the issuer has `AUTH_REQUIRED` set, then the
specified `Address::Contract` will need to be explicitly authorized before it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the respective function name here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@stellar-jenkins
Copy link

@sisuresh sisuresh merged commit b17627e into stellar-deprecated:dev Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants