-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spade shape #225
Add spade shape #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 98.42% 98.47% +0.04%
==========================================
Files 43 43
Lines 1775 1832 +57
Branches 358 357 -1
==========================================
+ Hits 1747 1804 +57
Misses 25 25
Partials 3 3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @kunxianhuang! I pushed some changes to clean things up after working with the code from the other PR. Can you please add a test class for the spade?
You can start from what was in #195:
data-morph/tests/shapes/test_points.py
Lines 147 to 156 in 4d3ed9d
class TestSpade(PointsModuleTestBase): | |
"""Test the Spade class.""" | |
shape_name = 'spade' | |
distance_test_cases = [ | |
[(20.02810385, 75.43271708), 0], | |
[(29.90222827231392, 63.4652469587905), 0], | |
[(19.52424889753761, 60.33944515816489), 0], | |
[(20, 75), 0.2214756], | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help with this one @kunxianhuang!
Fixes #163
Describe your changes
Add spade shape
Checklist