Add spade shape #195
Add spade shape #195
Conversation
github-actions
bot
added
testing
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first pull request to Data Morph! Please familiarize yourself with the contributing guidelines, if you haven't already.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 98.42% 98.43% +0.01%
==========================================
Files 43 43
Lines 1775 1792 +17
Branches 358 360 +2
==========================================
+ Hits 1747 1764 +17
Misses 25 25
Partials 3 3
|
There was a problem hiding this comment.
Thank you for the PR, @kevinr1299 – I'm very excited for this shape!
| from data_morph.data.loader import DataLoader | ||
| from data_morph.shapes.points import Heart | ||
|
|
||
| _ = Spade(DataLoader.load_dataset('panda')).plot() |
There was a problem hiding this comment.
This code gets executed while building the docs, so this won't work as is.
| from data_morph.data.loader import DataLoader | |
| from data_morph.shapes.points import Heart | |
| _ = Spade(DataLoader.load_dataset('panda')).plot() | |
| from data_morph.data.loader import DataLoader | |
| from data_morph.shapes.points import Spade | |
| _ = Spade(DataLoader.load_dataset('panda')).plot() |
| # Graph heart curve | ||
| x_shift = sum(x_bounds) / 2 | ||
| y_shift = sum(y_bounds) / 2 | ||
|
|
||
| t = np.linspace(-3, 3, num=90) | ||
|
|
||
| heart_x = -(16 * np.sin(t) ** 3) | ||
| heart_y = -( | ||
| 13 * np.cos(t) - 5 * np.cos(2 * t) - 2 * np.cos(3 * t) - np.cos(4 * t) | ||
| ) |
There was a problem hiding this comment.
Since we are using the heart equations, we should share the logic rather than duplicate it.
| # Graph left wing | ||
| left_t = np.linspace(-6, 0, num=12) | ||
| left_x = left_t | ||
| left_y = [0.278 * math.pow(point + 6.0, 2) - 16.0 for point in left_t] |
There was a problem hiding this comment.
Let's use numpy instead of math and vectorize this. https://numpy.org/doc/stable/reference/generated/numpy.power.html
| line_t = np.linspace(-6, 6, num=12) | ||
| line_x = line_t | ||
| line_y = [-16 for _ in line_t] |
There was a problem hiding this comment.
What about this?
| line_t = np.linspace(-6, 6, num=12) | |
| line_x = line_t | |
| line_y = [-16 for _ in line_t] | |
| line_x = np.linspace(-6, 6, num=12) | |
| line_y = np.repeat(-16, 12) |
| @@ -1,6 +1,7 @@ | |||
| """Shapes that are composed of points.""" | |||
|
|
|||
| import itertools | |||
| import math | |||
There was a problem hiding this comment.
We should be able to just use numpy here.
| import math |
|
This was completed in #225. |
Fixes #163
Describe your changes
Add the logic to morph into a spade shape
Checklist