Rewrite diff check algorithm + improve performance + fix linter fixes #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
force-pushed
the
fix-updateMessages
branch
3 times, most recently
from
bc078e5
to
ffe3966
Compare
aminya
force-pushed
the
fix-updateMessages
branch
from
ffe3966
to
00b2ebd
Compare
aminya
force-pushed
the
fix-updateMessages
branch
from
00b2ebd
to
8db6c1c
Compare
The original code by mistake set the changed to false in the first run. In the subsequent runs the diff checker was not being triggered at all!
This causes the UI and linter go out of sync!
aminya
force-pushed
the
fix-updateMessages
branch
from
5b460af
to
78838ba
Compare
update function requires the input messages to be normalized. It does not update the keys itself anymore (relies on LinterRegistry.lint to do it)
aminya
changed the title
Changes the old test which was: checks if an old message has updated, if so invalidates it properly
Set cannot compare complex objects
aminya
force-pushed
the
fix-updateMessages
branch
from
962fb18
to
ac78e02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This updates the way messages are filtered. The previous code was not flagging messages as added, removed, or kept correctly. A highly optimized algorithm is written to do the diff checking.
It greatly improves the performance of linter by not sending messages that are already rendered to linter-ui.
Fixes steelbrain/linter-ui-default#580
Fixes #1709
should be merged with steelbrain/linter-ui-default#581