?: update messages by value

steelbrain · Aug 2, 2020 · 00b2ebd · 00b2ebd
1 parent 129959d
commit 00b2ebd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/helpers.js b/lib/helpers.js
@@ -118,6 +118,7 @@ export function updateKeys(messages: Array<Message>) {
   for (let i = 0, { length } = messages; i < length; ++i) {
     messages[i].key = messageKey(messages[i])
   }
+  return messages
 }
 
 // create a map from keys to messages

diff --git a/lib/message-registry.js b/lib/message-registry.js
@@ -76,10 +76,10 @@ class MessageRegistry {
         continue
       }
 
-      const { oldMessages } = entry
+      let { oldMessages } = entry
 
       // update the key of oldMessages
-      updateKeys(oldMessages)
+      oldMessages = updateKeys(oldMessages)
 
       // create a map from keys to oldMessages
       const keyMessageMap = createKeyMessageMap(oldMessages)