Do not minify development bundles by default #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turning off minification speeds up bundle creation - Fixes an issue with incorrect module detection caused by minified dev bundles (steal-tools appends a module that preloads package.json files to prevent requests of the bundled modules, if the package.json files include glob patterns it will break Steal.js module detection, only happens when the bundle is minified) Closes steal/1227
1 task
|
@matthewp said this is the most beautiful PR he has ever reviewed so I have no option but to merge it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minified dev bundles (steal-tools appends a module that
preloads package.json files to prevent requests of the bundled
modules, if the package.json files include glob patterns it will
break Steal.js module detection, only happens when the bundle
is minified)
Closes stealjs/steal#1227