Development Bundles doesn't work

[pYr0x]

How often can you reproduce it?

• Always

Description:
i installed steal and steal-tools on a fresh project.
i want to create a deps bundle. i followed the guides https://stealjs.com/docs/StealJS.guides.development_bundles.html#add-npm-script-to-generate-the-bundle and added the new script tag <script src="node_modules/steal/steal.js" deps-bundle></script>

Steps to reproduce:

1. clone repo https://github.com/pYr0x/jss-steal-app
2. npm install
3. npm run deps-bundle

Expected results:
the dev.html is working.

Actual results:
i get an error:

TypeError: define is not a function
	    at Object.eval (http://localhost:63342/jss-steal-app/dev-bundle.js:4:110682)
	    at eval (http://localhost:63342/jss-steal-app/dev-bundle.js:5:4)
	    at eval (http://localhost:63342/jss-steal-app/dev-bundle.js:5:98)
	Evaluating http://localhost:63342/jss-steal-app/dev-bundle.js null

Environment:

Software	Version
Steal version	1.5.5
Steal-tools version	1.7.0
node -v	6
npm -v	3.10
Browser	chrome
Operating system	mac

[pYr0x]

Any suggestions @m-mujica ?

[m-mujica]

@pYr0x I haven't looked into this yet.... Once I'm done with my current issue I'll see what I can do, I'll let you know.

[pYr0x]

Ok thanks

[m-mujica]

@pYr0x I can see the error, seems to be caused by the minifier.

I'm looking deep into it but while I get a fix you could just pass --no-minify to the bundle command and it should load fine (and it should still be faster that loading each dep individually)

"deps-bundle": "steal-tools bundle --deps --no-minify"

Thanks for the example app, I'll update this issue once I find/fix the problem.

[matthewp]

Am I wrong in thinking that dev bundles are unminified by default?

[m-mujica]

@matthewp I can't remember, looking at the code now. 😬

[m-mujica]

@matthewp https://github.com/stealjs/steal-tools/blob/master/lib/build/bundle.js#L20

[m-mujica]

@matthewp the piece of code the bundle command adds to preload the bundled packages breaks the comments regex applied to the source code in the amd extension (the package json files sometime include glob patters like "/*.js" and that breaks the regex)

steal/src/base/lib/extension-amd.js

Line 292 in 65c62a5

sourceWithoutComments = load.source.replace(strictCommentRegEx, '$1'),

So the bundle's format is set to cjs instead of amd.

[pYr0x]

I wonder if there is no test for the deps bundle?
Can we not set that midule pre definded as amd, with the meta config ?

[m-mujica]

I wonder if there is no test for the deps bundle?

sure, there are tests https://github.com/stealjs/steal-tools/blob/master/test/dev_bundle_build_test.js, the bug will show up only if a dependency package.json has a `"/*" in one of its properties.

Can we not set that midule pre definded as amd, with the meta config ?

maybe, not sure how though.

[pYr0x]

You are talking about that piece of code ?
https://github.com/stealjs/steal-tools/blob/master/lib/bundle/add_npm_packages_node.js

[matthewp]

Should dev bundles be unminified? I can't think of when/why you'd want them to be minified. Just takes longer to build that way.

[m-mujica]

I think we should have made that the default, I can't remember why we did not do it.

I'm in to change it though.

[matthewp]

So if we just make that the default that takes away this bug, right?

[m-mujica]

@matthewp yup, there you go stealjs/steal-tools#905