Fix: "blazor.boot.json.gz" and "blazor.boot.json.br" are removed undesirably #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sirably - Recompress them after updating the "blazor.boot.json"
|
Great work @jsakamoto and @stavroskasidis |
|
Thank you for your contribution. Looks great. I will merge and publish asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, thank you for your great work!
By the way, this package will remove compressed "blazor.boot.json" files after the renaming process (The source code is here and here). Unfortunately, that behavior caused the runtime error when the Blazor Wasm app tried to load the compressed version of the "blazor.boot.json" file at its startup.
So, could you accept this pull request containing the program's changes to make it recompress the updated "blazor.boot.json" file?
P.S. I updated the target framework version of the build task project from "netstandard2.0" to "net6.0" to use the "System.IO.Compression.Brotli" to recompress the "blazor.boot.json" with Brotli algorithm. ("System.IO.Compression.Brotli" class is not contained in the ".NET Standard 2.0" specification.) I think this target framework changins is no matter because this package is already depends on .NET SDK ver.6.0.