Publish fails when blazor app uses BlazorWasmAntivirusProtection Nuget in the project #22

fingers10 · 2022-11-02T02:56:08Z

Sometimes blazor apps dlls are flagged as false positive and blocked by firewalls or antiviruses. There is already an issue 36978 tracking this.

Meanwhile there is an another great library BlazorWasmAntivirusProtection which is used to overcome this false flagging of blazor apps by antivirus or firewall.

When we use this BlazorWasmAntivirusProtection library and try to prerender, publish fails!!!.

Here is the repo - BlazorWasmAVPrerender to replicate the issue.

Error log:

BlazorWasmAVPrerender -> /home/runner/work/BlazorWasmAVPrerender/BlazorWasmAVPrerender/dist/BlazorWasmAVPrerender/
  Unhandled exception. System.Exception: Could not load the assembly "BlazorWasmAVPrerender" in search directories below.
  /home/runner/work/BlazorWasmAVPrerender/BlazorWasmAVPrerender/dist/BlazorWasmAVPrerender/wwwroot/_framework
  (pwd: /home/runner/work/BlazorWasmAVPrerender/BlazorWasmAVPrerender/BlazorWasmAVPrerender)
   ---> System.BadImageFormatException: Could not load file or assembly 'BlazorWasmAVPrerender, Culture=neutral, PublicKeyToken=null'. An attempt was made to load a program with an incorrect format.
  
  File name: 'BlazorWasmAVPrerender, Culture=neutral, PublicKeyToken=null' ---> System.BadImageFormatException: Bad IL format.
     at System.Runtime.Loader.AssemblyLoadContext.InternalLoad(ReadOnlySpan`1 arrAssembly, ReadOnlySpan`1 arrSymbols)
     at System.Runtime.Loader.AssemblyLoadContext.LoadFromStream(Stream assembly, Stream assemblySymbols)
     at System.Runtime.Loader.AssemblyLoadContext.LoadFromStream(Stream assembly)
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.CustomAssemblyLoader.LoadAssemblyFrom(String assemblyDir, String assemblyName) in C:\Projects\My\Blazor\BlazorWasmPreRendering.Build\BlazorWasmPreRendering.Build\CustomAssemblyLoader.cs:line 36
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.CustomAssemblyLoader.<>c__DisplayClass1_0.<.ctor>b__1(String dir) in C:\Projects\My\Blazor\BlazorWasmPreRendering.Build\BlazorWasmPreRendering.Build\CustomAssemblyLoader.cs:line 20
     at System.Linq.Enumerable.SelectListIterator`2.MoveNext()
     at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
     at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Boolean& found)
     at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source)
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.CustomAssemblyLoader.<.ctor>b__1_0(AssemblyLoadContext context, AssemblyName name) in C:\Projects\My\Blazor\BlazorWasmPreRendering.Build\BlazorWasmPreRendering.Build\CustomAssemblyLoader.cs:line 19
     at System.Runtime.Loader.AssemblyLoadContext.GetFirstResolvedAssemblyFromResolvingEvent(AssemblyName assemblyName)
     at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingEvent(AssemblyName assemblyName)
     at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingResolvingEvent(IntPtr gchManagedAssemblyLoadContext, AssemblyName assemblyName)
     at System.Reflection.RuntimeAssembly.InternalLoad(ObjectHandleOnStack assemblyName, ObjectHandleOnStack requestingAssembly, StackCrawlMarkHandle stackMark, Boolean throwOnFileNotFound, ObjectHandleOnStack assemblyLoadContext, ObjectHandleOnStack retAssembly)
     at System.Reflection.RuntimeAssembly.InternalLoad(AssemblyName assemblyName, RuntimeAssembly requestingAssembly, StackCrawlMark& stackMark, Boolean throwOnFileNotFound, AssemblyLoadContext assemblyLoadContext)
     at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyName(AssemblyName assemblyName)
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.CustomAssemblyLoader.LoadAssembly(String assemblyName) in C:\Projects\My\Blazor\BlazorWasmPreRendering.Build\BlazorWasmPreRendering.Build\CustomAssemblyLoader.cs:line 49
     --- End of inner exception stack trace ---
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.CustomAssemblyLoader.LoadAssembly(String assemblyName) in C:\Projects\My\Blazor\BlazorWasmPreRendering.Build\BlazorWasmPreRendering.Build\CustomAssemblyLoader.cs:line [55](https://github.com/fingers10/BlazorWasmAVPrerender/actions/runs/3374441807/jobs/5600065526#step:7:56)
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.Program.BuildPrerenderingOptions(CustomAssemblyLoader assemblyLoader, CommandLineOptions commandLineOptions) in C:\Projects\My\Blazor\BlazorWasmPreRendering.Build\BlazorWasmPreRendering.Build\Program.cs:line 103
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.Program.Main(String[] args) in C:\Projects\My\Blazor\BlazorWasmPreRendering.Build\BlazorWasmPreRendering.Build\Program.cs:line 28
     at Toolbelt.Blazor.WebAssembly.PrerenderServer.Program.<Main>(String[] args)
  Aborted (core dumped)

BlazorWasmAvPrerender GitHub Actions Link to check additional details if needed

The text was updated successfully, but these errors were encountered:

jsakamoto · 2022-11-02T13:07:20Z

@fingers10 Thank you for reporting!
I'm investigation this issue. It must be tough work, but I'll try to resolve the problem.

jsakamoto · 2022-11-03T13:38:12Z

@fingers10
Could you try out the ver.2.0.0-preview.4?

https://www.nuget.org/packages/BlazorWasmPreRendering.Build/2.0.0-preview.4

fingers10 · 2022-11-03T15:22:25Z

@jsakamoto , I tried the new package. Publish is successful. Here is the link.

However, I noticed two issues.

Error related to brotliloader.min.js

Navigation makes full page reload. Try clicking on any links in the link.
Counter button click not working.

jsakamoto · 2022-11-04T14:14:24Z

@fingers10
Actually, I found that that problem is careless of the BlazorWasmAVPrerender side. Fortunately, I also found a workaround. Could you try out the workaround I sent you as a pull request?

Workaround: brotli loader fails to load the "blazor.boot.json.br" fingers10/BlazorWasmAVPrerender#1

fingers10 · 2022-11-04T14:20:05Z

@fingers10
Actually, I found that that problem is careless of the BlazorWasmAVPrerender side. Fortunately, I also found a workaround. Could you try out the workaround I sent you as a pull request?

Workaround: brotli loader fails to load the "blazor.boot.json.br" fingers10/BlazorWasmAVPrerender#1

@jsakamoto lemme check and get back. Meanwhile with due diligence can we raise this issue in respective repo if it can help other consumers?

jsakamoto · 2022-11-05T03:31:07Z

@fingers10
Hi,

Meanwhile with due diligence can we raise this issue in respective repo if it can help other consumers?

Yes, I strongly agree with that your opinion.
So, I created and sent a pull request to the author of the "BlazorWasmAntivirusProtection" to resolve this problem.

Fix: "blazor.boot.json.gz" and "blazor.boot.json.br" are removed undesirably stavroskasidis/BlazorWasmAntivirusProtection#32

I hope the pull request above will be accepted and resolve the problem.

fingers10 · 2022-11-08T19:59:47Z

@jsakamoto BlazorWasmAntivirusProtection Package approved the PR and published it. Now the workaround that you have suggested in the .csproj in the sample repo is not needed right?

  <Target Name="_RecompressBlazorBootJson" AfterTargets="_ChangeDLLFileExtensions">

    <ItemGroup>
      <_BlazorBootJsonToRecompress Include="$(PublishDir)wwwroot\_framework\blazor.boot.json"></_BlazorBootJsonToRecompress>
    </ItemGroup>

    <GZipCompress
        Condition="!Exists('$(PublishDir)wwwroot\_framework\blazor.boot.json.gz')"
        FilesToCompress="@(_BlazorBootJsonToRecompress)"
        OutputDirectory="$(PublishDir)wwwroot\_framework\">
      <Output TaskParameter="CompressedFiles" ItemName="_BlazorBootJsonGZipRecompressed" />
    </GZipCompress>
    <Move SourceFiles="@(_BlazorBootJsonGZipRecompressed)" DestinationFiles="$(PublishDir)wwwroot\_framework\blazor.boot.json.gz" />

    <BrotliCompress
        Condition="!Exists('$(PublishDir)wwwroot\_framework\blazor.boot.json.br')"
        FilesToCompress="@(_BlazorBootJsonToRecompress)"
        OutputDirectory="$(PublishDir)wwwroot\_framework\"
        CompressionLevel="$(_BlazorBrotliCompressionLevel)"
        SkipIfOutputIsNewer="$(_BlazorWebAssemblyBrotliIncremental)"
        ToolAssembly="$(_BlazorWebAssemblySdkToolAssembly)"
        ToolExe="$(_DotNetHostFileName)"
        ToolPath="$(_DotNetHostDirectory)">
      <Output TaskParameter="CompressedFiles" ItemName="_BlazorBootJsonBrotliRecompressed" />
    </BrotliCompress>
    <Move SourceFiles="@(_BlazorBootJsonBrotliRecompressed)" DestinationFiles="$(PublishDir)wwwroot\_framework\blazor.boot.json.br" />

  </Target>

jsakamoto · 2022-11-12T06:49:07Z

@fingers10 Sorry too late since I was busy watching the .NET Conf 2022 that was held this week. (I live in Japan, so I had to wake up at midnight in the Japan Standard Time zone and keep staying up).

Now the workaround that you have suggested in the .csproj in the sample repo is not needed right?

Yes, that's right, it should work well even after removing that workaround.
However, please remember that I've not verified it yet in my hand.

fingers10 · 2022-11-12T06:56:49Z

@fingers10 Sorry too late since I was busy watching the .NET Conf 2022 that was held this week. (I live in Japan, so I had to wake up at midnight in the Japan Standard Time zone and keep staying up).

Now the workaround that you have suggested in the .csproj in the sample repo is not needed right?

Yes, that's right, it should work well even after removing that workaround.
However, please remember that I've not verified it yet in my hand.

@jsakamoto No worries. Yep I know that you are watching .NET Conf 22. I saw your question on C# required properties. Your question was too specific on adding required to property injection in blazor. Good question.

Back to this issue. I'll validate this and get back.

fingers10 · 2022-11-12T17:06:36Z

@jsakamoto Just confirmed. Prerendering is working with BlazorWasmAntivirusProtection 1.9.0 without the work around in .csproj file.

fingers10 · 2022-11-20T01:02:44Z

@jsakamoto I noticed that publish fails when we have lazy loading enabled with BalzorWasmAntivirusProtection. The issue happens in the same sample repo. Please can we reopen and investigate further?

jsakamoto · 2022-11-20T14:42:25Z

@fingers10 I'm currently investigating the revival problem. I'll inform you the progress as soon as I can.

jsakamoto · 2022-11-20T23:32:41Z

@fingers10 The latest version of the "BlazorWasmPreRendering.Build" has now supported the latest version of the "BlazorWasmAntivirusProtection". Please check it out.

https://www.nuget.org/packages/BlazorWasmPreRendering.Build/2.0.0-preview.6#release-body-tab

However, your sample project still failed because the project uses the "lazy assembly loading" feature of Blazor WebAssembly.

Again, the "BlazorWasmPreRendering.Build" depends on the pre-rendering feature of the Blazor Server. The "BlazorWasmPreRendering.Build" is implemented pre-rendering feature by making a Blazor WebAssembly app run as a Blazor Server app forcibly with some hacking. But these magics are not applicable for the "lazy assembly loading" feature because that feature is very specific on the client side running.

I'll try to add support for the "lazy assembly loading" feature to the "BlazorWasmPreRendering.Build" later, but it must be very tough work, and please keep your mind that it might be impossible.

jsakamoto · 2022-11-22T12:42:27Z

@fingers10 Now the latest version of the "BlazorWasmPreRendering.Build" has supported lazy loading assemblies! 🎉

https://www.nuget.org/packages/BlazorWasmPreRendering.Build/2.0.0-preview.7#release-body-tab

Could you check it out? and, thank you for giving me the big challenge that is adding support for lazy loading assemblies!

fingers10 · 2022-11-22T13:05:50Z

@jsakamoto salute to you. You are making a great solutions. You earned my respect a lot. I'll check this and keep you posted

fingers10 · 2022-11-22T16:26:34Z

@jsakamoto I have noticed few observations.

Publish keeps running when I publish via Visual Studio 2022 v 17.4.1 . I ended up terminating manually. Is this switch turned on by default or any new settings needs to be configured to cancel this?

The pre-rendering server will keep running because the "-k" option switch is specified.

logs:

BlazorWasmAVPrerender -> C:\Repos\BlazorWasmAVPrerender\BlazorWasmAVPrerender\obj\Release\net7.0\browser-wasm\PubTmp\Out\
dotnet "C:\Users\abcd\.nuget\packages\blazorwasmprerendering.build\2.0.0-preview.7\build\../tools/net7.0/BlazorWasmPreRendering.Build.dll" -a "BlazorWasmAVPrerender" -t "BlazorWasmAVPrerender.App" --selectorofrootcomponent "#app,app" --selectorofheadoutletcomponent "head::after" -p "C:\Repos\BlazorWasmAVPrerender\BlazorWasmAVPrerender\obj\Release\net7.0\browser-wasm\PubTmp\Out" -i "C:\Repos\BlazorWasmAVPrerender\BlazorWasmAVPrerender\obj\Release\net7.0\." -m "" -f "net7.0" --serviceworkerassetsmanifest "" --environment "Prerendering" --emulateauthme "true" --locale "en" -o "IndexHtmlInSubFolders"  -k -d -u "" -r "WebAssemblyPrerendered" --serverport "5050-5999" --bwapoptionsdllext "dat"
Start fetching...[http://127.0.0.1:5050]
Getting http://127.0.0.1:5050/...
Getting http://127.0.0.1:5050/counter...
Getting http://127.0.0.1:5050/fetchdata...
Fetching complete.

The pre-rendering server will keep running because the "-k" option switch is specified.
To stop the pre - rendering server and stop build, press Ctrl + C.
Build has been canceled.
========== Elapsed 15:01.876 ==========

Tried publishing via github actions - link. This also keeps on running but not displayin any logs.

jsakamoto · 2022-11-22T23:54:47Z

@fingers10
It seems because you specified the BlazorWasmPrerenderingKeepServer MSBuild property to true explicitly, doesn't it?

https://github.com/fingers10/BlazorWasmAVPrerender/blob/master/BlazorWasmAVPrerender/BlazorWasmAVPrerender.csproj#L14

fingers10 · 2022-11-23T01:13:51Z

@jsakamoto ah ha.. I'm wondering how this flag was set to true in the codebase. I couldn't remember...but history shows this was added along with Nuget Update commit. Never mind.

It's good it works with simple scenarios.. lemme check with production project and share my updates.

fingers10 · 2022-11-23T01:51:30Z

@jsakamoto for some reason the publish fails in github actions deploy. Here is the link.

Error:

The type initializer for 'Brotli.Brolib64' threw an exception

Logs:

/home/runner/.nuget/packages/blazorwasmantivirusprotection/2.2.1/build/net7.0/BlazorWasmAntivirusProtection.targets(36,3): error : The type initializer for 'Brotli.Brolib64' threw an exception. [/home/runner/work/ilovedotnet/ilovedotnet/Web/Web.csproj]
  BlazorWasmAntivirusProtection: Renaming .dll files to .dat finished
Error: Process completed with exit code 1.

jsakamoto · 2022-11-23T05:08:58Z

@fingers10 I could not reproduce the error with that I forked the "ILoveDotNet/ilovedotnet" repository, hard reset the main branch point to the commit 66c8265f, and re-run the gh-pages workflow forcibly. (The log line is here)

Moreover, the error you reported seems telling us that the reason of the error comes from the "BlazorWasmAntivirusProtection" package, not the "BlazorWasmPreRendering.Build" package.

I would like to recommend:

Try again with re-enabling the "BlazorWasmAntivirus". If there was no error, I guess that the error may be temporary, and it may depend on some environmental factors of GitHub Actions virtual machine.
If the same error came back again, then please remove the "BlazorWasmPreRendering.Build" package from project and try again. If the same error was still there, the error must be from the "BlazorWasmAntivirus", so prelase report it to the issue thread of the "BlazorWasmAntivirus" repository.

fingers10 · 2022-11-25T11:18:14Z

@jsakamoto Many thanks for your suggestions and guidance. This thread can be closed.

jsakamoto · 2022-11-25T12:49:10Z

Thanks!

jsakamoto mentioned this issue Nov 4, 2022

Workaround: brotli loader fails to load the "blazor.boot.json.br" fingers10/BlazorWasmAVPrerender#1

Merged

jsakamoto mentioned this issue Nov 5, 2022

Fix: "blazor.boot.json.gz" and "blazor.boot.json.br" are removed undesirably stavroskasidis/BlazorWasmAntivirusProtection#32

Merged

jsakamoto closed this as completed Nov 13, 2022

jsakamoto mentioned this issue Nov 20, 2022

The "BlazorWasmAntivirusProtection.Tasks.CleanOldDlls" task could not be loaded stavroskasidis/BlazorWasmAntivirusProtection#36

Closed

jsakamoto reopened this Nov 20, 2022

jsakamoto closed this as completed Nov 25, 2022

fingers10 mentioned this issue Nov 29, 2023

After .NET 8 update appsettings.json.br not found after publishing to github pages #41

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish fails when blazor app uses BlazorWasmAntivirusProtection Nuget in the project #22

Publish fails when blazor app uses BlazorWasmAntivirusProtection Nuget in the project #22

fingers10 commented Nov 2, 2022 •

edited

Loading

jsakamoto commented Nov 2, 2022

jsakamoto commented Nov 3, 2022

fingers10 commented Nov 3, 2022 •

edited

Loading

jsakamoto commented Nov 4, 2022

fingers10 commented Nov 4, 2022

jsakamoto commented Nov 5, 2022

fingers10 commented Nov 8, 2022

jsakamoto commented Nov 12, 2022

fingers10 commented Nov 12, 2022 •

edited

Loading

fingers10 commented Nov 12, 2022

fingers10 commented Nov 20, 2022 •

edited

Loading

jsakamoto commented Nov 20, 2022

jsakamoto commented Nov 20, 2022

jsakamoto commented Nov 22, 2022

fingers10 commented Nov 22, 2022

fingers10 commented Nov 22, 2022

jsakamoto commented Nov 22, 2022

fingers10 commented Nov 23, 2022

fingers10 commented Nov 23, 2022

jsakamoto commented Nov 23, 2022

fingers10 commented Nov 25, 2022

jsakamoto commented Nov 25, 2022

Publish fails when blazor app uses BlazorWasmAntivirusProtection Nuget in the project #22

Publish fails when blazor app uses BlazorWasmAntivirusProtection Nuget in the project #22

Comments

fingers10 commented Nov 2, 2022 • edited Loading

jsakamoto commented Nov 2, 2022

jsakamoto commented Nov 3, 2022

fingers10 commented Nov 3, 2022 • edited Loading

jsakamoto commented Nov 4, 2022

fingers10 commented Nov 4, 2022

jsakamoto commented Nov 5, 2022

fingers10 commented Nov 8, 2022

jsakamoto commented Nov 12, 2022

fingers10 commented Nov 12, 2022 • edited Loading

fingers10 commented Nov 12, 2022

fingers10 commented Nov 20, 2022 • edited Loading

jsakamoto commented Nov 20, 2022

jsakamoto commented Nov 20, 2022

jsakamoto commented Nov 22, 2022

fingers10 commented Nov 22, 2022

fingers10 commented Nov 22, 2022

jsakamoto commented Nov 22, 2022

fingers10 commented Nov 23, 2022

fingers10 commented Nov 23, 2022

jsakamoto commented Nov 23, 2022

fingers10 commented Nov 25, 2022

jsakamoto commented Nov 25, 2022

fingers10 commented Nov 2, 2022 •

edited

Loading

fingers10 commented Nov 3, 2022 •

edited

Loading

fingers10 commented Nov 12, 2022 •

edited

Loading

fingers10 commented Nov 20, 2022 •

edited

Loading