Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove welcome screen from onboarding #20912

Merged
merged 12 commits into from
Sep 17, 2024

Conversation

jo-mut
Copy link
Contributor

@jo-mut jo-mut commented Jul 29, 2024

fixes #20724

Summary

This PR removes the welcome screen from the onboarding flow

Review notes

  • Open Status
  • Go through onboarding to Enable Notifications page
  • User is navigated to home page from enable notifications (Welcome page is removed)

Before and after screenshots comparison

Screen.Recording.2024-07-29.at.13.13.59.mov

Additionally, this PR fixes the customization color in the password disclaimer during the onboarding:

Before:
Screenshot from 2024-08-20 15-17-01

Now:
Screenshot from 2024-08-20 15-16-45

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jul 29, 2024

Jenkins Builds

Click to see older builds (39)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f91efb2 #1 2024-07-29 11:26:10 ~4 min tests 📄log
✔️ f91efb2 #1 2024-07-29 11:27:46 ~6 min android-e2e 🤖apk 📲
✔️ f91efb2 #1 2024-07-29 11:30:23 ~9 min android 🤖apk 📲
✔️ f91efb2 #1 2024-07-29 11:31:58 ~10 min ios 📱ipa 📲
✔️ 0f9862b #2 2024-07-29 14:47:54 ~4 min tests 📄log
✔️ 0f9862b #2 2024-07-29 14:49:31 ~6 min android-e2e 🤖apk 📲
✔️ 0f9862b #2 2024-07-29 14:51:00 ~7 min android 🤖apk 📲
✔️ 0f9862b #2 2024-07-29 14:52:02 ~8 min ios 📱ipa 📲
268af6f #3 2024-08-20 22:05:44 ~2 min tests 📄log
✔️ c420444 #5 2024-08-20 22:17:03 ~6 min android-e2e 🤖apk 📲
✔️ c420444 #5 2024-08-20 22:18:44 ~7 min android 🤖apk 📲
✔️ c420444 #5 2024-08-20 22:21:15 ~10 min ios 📱ipa 📲
✔️ f11e293 #6 2024-08-22 21:52:48 ~4 min tests 📄log
✔️ f11e293 #6 2024-08-22 21:56:42 ~8 min android-e2e 🤖apk 📲
✔️ f11e293 #6 2024-08-22 21:57:04 ~9 min android 🤖apk 📲
✔️ f11e293 #6 2024-08-22 21:57:19 ~9 min ios 📱ipa 📲
✔️ 71f4d16 #7 2024-09-09 20:19:21 ~4 min tests 📄log
✔️ 71f4d16 #7 2024-09-09 20:21:40 ~6 min android 🤖apk 📲
✔️ 71f4d16 #7 2024-09-09 20:22:26 ~7 min android-e2e 🤖apk 📲
✔️ 502c3df #8 2024-09-09 20:29:12 ~4 min tests 📄log
✔️ 502c3df #8 2024-09-09 20:31:24 ~6 min android 🤖apk 📲
✔️ 502c3df #8 2024-09-09 20:32:17 ~7 min android-e2e 🤖apk 📲
✔️ 502c3df #8 2024-09-09 20:48:48 ~23 min ios 📱ipa 📲
✔️ 024004a #9 2024-09-10 23:42:04 ~4 min tests 📄log
✔️ 024004a #9 2024-09-10 23:43:44 ~6 min android-e2e 🤖apk 📲
✔️ 024004a #9 2024-09-10 23:45:39 ~8 min android 🤖apk 📲
✔️ 024004a #9 2024-09-10 23:57:16 ~19 min ios 📱ipa 📲
0cda8516 #10 2024-09-13 22:32:56 ~2 min tests 📄log
✔️ 0cda8516 #10 2024-09-13 22:37:25 ~7 min android-e2e 🤖apk 📲
✔️ 0cda8516 #10 2024-09-13 22:37:53 ~7 min android 🤖apk 📲
✔️ 0cda8516 #10 2024-09-13 22:40:27 ~10 min ios 📱ipa 📲
✔️ 387e1a1 #11 2024-09-13 22:49:53 ~4 min tests 📄log
✔️ 387e1a1 #11 2024-09-13 22:52:50 ~7 min android-e2e 🤖apk 📲
✔️ 387e1a1 #11 2024-09-13 22:53:19 ~7 min android 🤖apk 📲
✔️ 387e1a1 #11 2024-09-13 22:54:29 ~8 min ios 📱ipa 📲
✔️ fdc5b10 #12 2024-09-16 12:31:05 ~4 min tests 📄log
✔️ fdc5b10 #12 2024-09-16 12:34:10 ~7 min android-e2e 🤖apk 📲
✔️ fdc5b10 #12 2024-09-16 12:34:39 ~7 min android 🤖apk 📲
✔️ fdc5b10 #12 2024-09-16 12:36:46 ~9 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 073e82c #13 2024-09-16 12:57:21 ~3 min tests 📄log
✔️ 073e82c #13 2024-09-16 13:00:55 ~7 min android-e2e 🤖apk 📲
✔️ 073e82c #13 2024-09-16 13:01:19 ~8 min android 🤖apk 📲
✔️ 073e82c #13 2024-09-16 13:05:04 ~11 min ios 📱ipa 📲
✔️ bcbdd28 #14 2024-09-17 16:25:45 ~3 min tests 📄log
✔️ bcbdd28 #14 2024-09-17 16:28:53 ~7 min android-e2e 🤖apk 📲
✔️ bcbdd28 #14 2024-09-17 16:29:23 ~7 min android 🤖apk 📲
✔️ bcbdd28 #14 2024-09-17 16:30:39 ~8 min ios 📱ipa 📲

@jo-mut jo-mut force-pushed the chore/remove-welcome-screen branch from f91efb2 to 0f9862b Compare July 29, 2024 14:42
@ulisesmac ulisesmac self-assigned this Aug 20, 2024
@ulisesmac ulisesmac force-pushed the chore/remove-welcome-screen branch from 0f9862b to 268af6f Compare August 20, 2024 22:02
@ulisesmac ulisesmac marked this pull request as ready for review August 20, 2024 22:04
@ulisesmac ulisesmac changed the title chore_: remove welcome screen from onboarding chore: remove welcome screen from onboarding Aug 20, 2024
Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariia-skrypnyk
Copy link

Hey @ulisesmac !

Thanks for picking it up!
Please, resolve the conflicts and rebase your PR.

@ulisesmac ulisesmac force-pushed the chore/remove-welcome-screen branch from f11e293 to 71f4d16 Compare September 9, 2024 20:14
@ulisesmac
Copy link
Contributor

@mariia-skrypnyk done!

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented Sep 10, 2024

Hey @ulisesmac !

Thanks for your PR.

I noticed one issue that is not exist on dev.

ISSUE 1: No Profile image till you give a permission to the notifications

Steps:

  1. Install app (both platforms)
  2. Go through onboarding and Enable Notifications

Actual result:

No Profile image untill you give notification permission( trully speaking just to make notifications permission popup close).

IMG_2336.MP4

In case Notification permission was denied then Profile image will be present.

IMG_2337.MP4

logs_profile.zip

Expected result:

Profile image should be present.

@ulisesmac
Copy link
Contributor

@mariia-skrypnyk

A quick explanation:
The issue happened because when we show a permision modal, the app freezes some processes, such as feching the image.

I moved the navigation to happen after the modal to request permissions, actually this behavior looks a lot better.

Please test again, thank you!.

@status-im-auto
Copy link
Member

0% of end-end tests have passed

Total executed tests: 7
Failed tests: 7
Expected to fail tests: 0
Passed tests: 0
IDs of failed tests: 727230,702843,727229,703133,702742,702745,727231 

Failed tests (7)

Click to expand
  • Rerun failed tests

  • Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231

    Device 1: Find `Button` by `accessibility id`: `enable-notifications-later-button`
    Device 1: Find `Button` by `accessibility id`: `welcome-button`

    Test setup failed: critical/test_wallet.py:202: in prepare_devices
        self.sign_in_view.create_user()
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Test setup failed: critical/test_wallet.py:29: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:305: in recover_access
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Button by accessibility id: welcome-button
    Device 1: Find Button by accessibility id: welcome-button

    Test setup failed: critical/test_wallet.py:29: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:305: in recover_access
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find Button by accessibility id: welcome-button
    Device 1: Find Button by accessibility id: welcome-button

    Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices
        self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find Button by accessibility id: welcome-button
    Device 1: Find Button by accessibility id: welcome-button

    Test setup failed: critical/chats/test_public_chat_browsing.py:311: in prepare_devices
        self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices
        self.home = self.sign_in.create_user(username=self.username)
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Find Button by accessibility id: enable-notifications-later-button
    Device 1: Find Button by accessibility id: welcome-button

    Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices
        self.home = self.sign_in.create_user(username=self.username)
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    @mariia-skrypnyk
    Copy link

    Hey @ulisesmac!

    Thanks for your explanation and fix.
    It works perfectly for Android but iOS looks the same.

    Screenshot 2024-09-11 at 11 12 08

    @ulisesmac
    Copy link
    Contributor

    Hey @ulisesmac!

    Thanks for your explanation and fix.
    It works perfectly for Android but iOS looks the same.

    Screenshot 2024-09-11 at 11 12 08

    Hi @mariia-skrypnyk

    Thanks for testing, I'll re check on iOS as soon as I can.

    @ulisesmac ulisesmac force-pushed the chore/remove-welcome-screen branch from 0cda851 to 387e1a1 Compare September 13, 2024 22:45
    @ulisesmac
    Copy link
    Contributor

    Hi @mariia-skrypnyk

    Could you please test it again? it has been fixed on both platforms.

    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 7
    Failed tests: 7
    Expected to fail tests: 0
    Passed tests: 0
    
    IDs of failed tests: 727230,703133,727231,702745,702742,727229,702843 
    

    Failed tests (7)

    Click to expand
  • Rerun failed tests

  • Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231

    Device 1: Find `Button` by `accessibility id`: `enable-notifications-later-button`
    Device 1: Find `Button` by `accessibility id`: `welcome-button`

    Test setup failed: critical/test_wallet.py:202: in prepare_devices
        self.sign_in_view.create_user()
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find Button by accessibility id: welcome-button
    Device 1: Find Button by accessibility id: welcome-button

    Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices
        self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Test setup failed: critical/test_wallet.py:29: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:305: in recover_access
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Button by accessibility id: welcome-button
    Device 1: Find Button by accessibility id: welcome-button

    Test setup failed: critical/test_wallet.py:29: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:305: in recover_access
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find Button by accessibility id: welcome-button
    Device 1: Find Button by accessibility id: welcome-button

    Test setup failed: critical/chats/test_public_chat_browsing.py:311: in prepare_devices
        self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:275: in create_user
        self.start_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices
        self.home = self.sign_in.create_user(username=self.username)
    ../views/sign_in_view.py:249: in create_user
        self.generate_keys_button.click_until_presence_of_element(self.profile_title_input)
    ../views/base_element.py:107: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:221: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:145: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:86: in until
        value = method(self._driver)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:152: in _predicate
        return _element_if_visible(driver.find_element(*locator))
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:409: in find_element
        return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value']
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
        self.error_handler.check_response(response)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
        raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
     An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up
    E   Stacktrace:
    E   UnknownError: An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up
    E       at UIA2Proxy.command (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/jsonwp-proxy/proxy.js:355:13)
    E       at processTicksAndRejections (node:internal/process/task_queues:95:5)
    E       at AndroidUiautomator2Driver.helpers.doFindElementOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/lib/commands/find.js:30:10)
    E       at doFind (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:36:17)
    E       at wrappedCondFn (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:137:14)
    E       at spin (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:221:20)
    E       at waitForCondition (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:238:10)
    E       at AndroidUiautomator2Driver.implicitWaitForCondition (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:139:12)
    E       at AndroidUiautomator2Driver.findElOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:60:5)
    E       at AndroidUiautomator2Driver.findElOrElsWithProcessing (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:60:12)
    E       at AndroidUiautomator2Driver.findElement (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:75:12)
    



    2. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Tap on found: Button
    Device 1: Click until EditBox by accessibility id: profile-title-input will be presented

    Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices
        self.home = self.sign_in.create_user(username=self.username)
    ../views/sign_in_view.py:249: in create_user
        self.generate_keys_button.click_until_presence_of_element(self.profile_title_input)
    ../views/base_element.py:107: in click_until_presence_of_element
        while not desired_element.is_element_displayed(1) and counter <= attempts:
    ../views/base_element.py:221: in is_element_displayed
        return self.wait_for_visibility_of_element(sec, ignored_exceptions=ignored_exceptions)
    ../views/base_element.py:145: in wait_for_visibility_of_element
        .until(expected_conditions.visibility_of_element_located((self.by, self.locator)))
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/support/wait.py:86: in until
        value = method(self._driver)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/support/expected_conditions.py:152: in _predicate
        return _element_if_visible(driver.find_element(*locator))
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:409: in find_element
        return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value']
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
        self.error_handler.check_response(response)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
        raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
     An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up
    E   Stacktrace:
    E   UnknownError: An unknown server-side error occurred while processing the command. Original error: Could not proxy command to the remote server. Original error: socket hang up
    E       at UIA2Proxy.command (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/jsonwp-proxy/proxy.js:355:13)
    E       at processTicksAndRejections (node:internal/process/task_queues:95:5)
    E       at AndroidUiautomator2Driver.helpers.doFindElementOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/lib/commands/find.js:30:10)
    E       at doFind (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:36:17)
    E       at wrappedCondFn (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:137:14)
    E       at spin (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:221:20)
    E       at waitForCondition (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:238:10)
    E       at AndroidUiautomator2Driver.implicitWaitForCondition (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:139:12)
    E       at AndroidUiautomator2Driver.findElOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:60:5)
    E       at AndroidUiautomator2Driver.findElOrElsWithProcessing (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:60:12)
    E       at AndroidUiautomator2Driver.findElement (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:75:12)
    



    Device sessions

    @status-im-auto
    Copy link
    Member

    14% of end-end tests have passed

    Total executed tests: 7
    Failed tests: 6
    Expected to fail tests: 0
    Passed tests: 1
    
    IDs of failed tests: 727230,703133,727231,702742,727229,702843 
    

    Failed tests (6)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices
        self.home = self.sign_in.create_user(username=self.username)
    ../views/sign_in_view.py:273: in create_user
        self.maybe_later_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `enable-notifications-later-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_community_copy_and_paste_message_in_chat_input, id: 702742

    Device 1: Tap on found: Button
    Device 1: Find Button by accessibility id: enable-notifications-later-button

    Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices
        self.home = self.sign_in.create_user(username=self.username)
    ../views/sign_in_view.py:273: in create_user
        self.maybe_later_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `enable-notifications-later-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231

    Device 1: Find Button by xpath: //*[@text="Cancel" or @text="CANCEL"]
    Device 1: Tap on found: Button

    Test setup failed: critical/test_wallet.py:202: in prepare_devices
        self.sign_in_view.create_user()
    ../views/sign_in_view.py:275: in create_user
        self.chats_tab.wait_for_visibility_of_element(30)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: ChatsTab by accessibility id:`chats-stack-tab` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Find Button by accessibility id: enable-notifications-later-button
    ## New multiaccount is created successfully!

    Test setup failed: critical/chats/test_public_chat_browsing.py:311: in prepare_devices
        self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:273: in create_user
        self.maybe_later_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 2: Button by accessibility id: `enable-notifications-later-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Test setup failed: critical/test_wallet.py:29: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:302: in recover_access
        self.maybe_later_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `enable-notifications-later-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_wallet_send_eth, id: 727229

    Device 1: Tap on found: Button
    Device 1: Find Button by accessibility id: enable-notifications-later-button

    Test setup failed: critical/test_wallet.py:29: in prepare_devices
        self.loop.run_until_complete(
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:52: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    ../views/sign_in_view.py:302: in recover_access
        self.maybe_later_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `enable-notifications-later-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Passed tests (1)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    @yevh-berdnyk yevh-berdnyk force-pushed the chore/remove-welcome-screen branch from fdc5b10 to 073e82c Compare September 16, 2024 12:53
    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 7
    Failed tests: 0
    Expected to fail tests: 0
    Passed tests: 7
    

    Passed tests (7)

    Click to expand

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    @yevh-berdnyk
    Copy link
    Contributor

    yevh-berdnyk commented Sep 16, 2024

    Hi @ulisesmac , thanks for the PR! I've updated e2e tests, please don't forget my commit when merging :)

    @mariia-skrypnyk
    Copy link

    Hi @ulisesmac !

    Looks much better and I suppose we can merge this PR.
    I still see issue with Profile image on iOS but we can investigate it as a follow up.

    IMG_2412.MP4

    @ulisesmac ulisesmac force-pushed the chore/remove-welcome-screen branch from 073e82c to bcbdd28 Compare September 17, 2024 16:21
    @ulisesmac ulisesmac merged commit a166275 into develop Sep 17, 2024
    6 checks passed
    @ulisesmac ulisesmac deleted the chore/remove-welcome-screen branch September 17, 2024 22:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Remove welcome screen from onboarding
    10 participants