-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove welcome screen from onboarding #20912
Conversation
Jenkins BuildsClick to see older builds (39)
|
f91efb2
to
0f9862b
Compare
src/status_im/contexts/onboarding/enable_notifications/view.cljs
Outdated
Show resolved
Hide resolved
0f9862b
to
268af6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/status_im/contexts/onboarding/enable_notifications/view.cljs
Outdated
Show resolved
Hide resolved
Hey @ulisesmac ! Thanks for picking it up! |
src/status_im/contexts/onboarding/enable_notifications/view.cljs
Outdated
Show resolved
Hide resolved
f11e293
to
71f4d16
Compare
@mariia-skrypnyk done! |
Hey @ulisesmac ! Thanks for your PR. I noticed one issue that is not exist on dev. ISSUE 1: No Profile image till you give a permission to the notifications Steps:
Actual result: No Profile image untill you give notification permission( trully speaking just to make notifications permission popup close). IMG_2336.MP4In case Notification permission was denied then Profile image will be present. IMG_2337.MP4Expected result: Profile image should be present. |
502c3df
to
024004a
Compare
A quick explanation: I moved the navigation to happen after the modal to request permissions, actually this behavior looks a lot better. Please test again, thank you!. |
0% of end-end tests have passed
Failed tests (7)Click to expandClass TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
Hey @ulisesmac! Thanks for your explanation and fix. |
Thanks for testing, I'll re check on iOS as soon as I can. |
0cda851
to
387e1a1
Compare
Could you please test it again? it has been fixed on both platforms. |
0% of end-end tests have passed
Failed tests (7)Click to expandClass TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
14% of end-end tests have passed
Failed tests (6)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Passed tests (1)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
|
fdc5b10
to
073e82c
Compare
100% of end-end tests have passed
Passed tests (7)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
Hi @ulisesmac , thanks for the PR! I've updated e2e tests, please don't forget my commit when merging :) |
Hi @ulisesmac ! Looks much better and I suppose we can merge this PR. IMG_2412.MP4 |
073e82c
to
bcbdd28
Compare
fixes #20724
Summary
This PR removes the welcome screen from the onboarding flow
Review notes
Before and after screenshots comparison
Screen.Recording.2024-07-29.at.13.13.59.mov
Additionally, this PR fixes the customization color in the password disclaimer during the onboarding:
Before:
Now:
status: ready