Implement seed phrase fallback flow #21090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (110)
|
Parveshdhull
force-pushed
the
feature/fallback-pairing-seed
branch
from
dcd662b to
07cc9bf
Compare
Parveshdhull
changed the title
Parveshdhull
force-pushed
the
feature/fallback-pairing-seed
branch
5 times, most recently
from
bf1f5b6 to
8dbcff2
Compare
Parveshdhull
force-pushed
the
feature/fallback-pairing-seed
branch
9 times, most recently
from
47af03c to
909d7a3
Compare
Parveshdhull
force-pushed
the
feature/fallback-pairing-seed
branch
4 times, most recently
from
27aa127 to
fc4c406
Compare
Parveshdhull
commented
Sep 3, 2024
Comment on lines
47
to
46
| (defn- show-check-before-syncing | ||
| (defn- navigate-to-new-to-status |
There was a problem hiding this comment.
Feel free to ignore this file. As its already reviewed in #21160
Parveshdhull
requested review from
ilmotta,
qfrank and
flexsurfer
and removed request for
ilmotta and
qfrank
100% of end-end tests have passedPassed tests (51)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
|
|
Hi @Parveshdhull ! |
|
Hi, thank you for finding this issue. It's unlikely that it's related to the PR. But just to be sure are you facing this on Android? And on which flow, fresh account? Please can you confirm, that you tried another device? |
|
@Parveshdhull This reproduces on both platforms (Android, iOS) and only in the fallback flow, regardless of the account. |
|
hi @Horupa-Olena, Thank you for finding this issue. It should be fixed now By the way, we missed this earlier, but it is also present in the Issue 2 video at 1:15. |
That's a good point. Maybe that's something we should bring up with designers to address soon after. While the flows are currently correct, they are a bit confusing like you pointed out. |
|
@Parveshdhull Thank you for your fix. No issues from my side. PR is ready to be merged! |
cc @qfrank |
waiting for PR approval from @igor-sirotin |
status-go changes merged @Parveshdhull |
Parveshdhull
force-pushed
the
feature/fallback-pairing-seed
branch
from
b8729e6 to
7d6bf2b
Compare
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR #20766
Designs: https://www.figma.com/design/V6nlpAWIf2e1XU8RJ9yQPe/Syncing-for-Mobile?node-id=3338-16100&node-type=CANVAS&t=yeQnRzRlEua9vV6V-0
depends on #21160 (PR merged)
status-go pr: status-im/status-go#5794
Leftover
As per design we also need to show profile name, but currently we don't have access to that. So only installation-id will be shown in more details bottom sheet.
Testing
status: ready