Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test bugfix on windows #20296

Closed
wants to merge 1 commit into from
Closed

test bugfix on windows #20296

wants to merge 1 commit into from

Conversation

cammellos
Copy link
Contributor

@cammellos cammellos commented May 31, 2024 •
edited
Loading

We will need to test creating new accounts and upgrading from previous version (any pr before this one).

status-im/status-go#5255

@cammellos cammellos requested a review from qfrank May 31, 2024 17:09
@cammellos cammellos self-assigned this May 31, 2024
@cammellos cammellos force-pushed the 5186-cannot-login-on-windows branch from abf5f81 to a6567c3 Compare May 31, 2024 17:13
@jrainville jrainville mentioned this pull request May 31, 2024
Closed
@status-im-auto
Copy link
Member

status-im-auto commented May 31, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a6567c3 #2 2024-05-31 17:18:09 ~4 min tests 📄log
✔️ a6567c3 #2 2024-05-31 17:27:11 ~13 min android-e2e 🤖apk 📲
✔️ a6567c3 #2 2024-05-31 17:28:22 ~14 min ios 📱ipa 📲
✔️ a6567c3 #2 2024-05-31 17:28:40 ~15 min android 🤖apk 📲

@pavloburykh pavloburykh self-assigned this Jun 3, 2024
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 51
Failed tests: 3
Expected to fail tests: 3
Passed tests: 45
Not executed tests: 1

IDs of not executed tests: 702936 

IDs of failed tests: 727230,727229,703629 

IDs of expected to fail tests: 703495,703503,727232

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1184: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Joined status is not displayed
E    open community is not listed inside Joined communities tab



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:120: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:41: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Tap on found: LogInButton
    Device 1: Find Button by accessibility id: done 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:88: in confirm_transaction
    self.done_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (3)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:214: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (45)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    Hey @cammellos! Thanks for the PR. Please take a look at the issue.

    ISSUE 1 "App is not installed as package appears to be valid" when upgrading from the older app version (Android)

    Android only. Tested on Samsung Galaxy A52, Android 12

    Steps:

    1. Install build from some other PR (I used latest build from this PR [#20165] feat: import a missing key pair by scanning QR code #20280)
    2. Create/restore an account
    3. Try to install build from current PR on top of other build to test upgrade
    4. Observe the error

    Actual result: "App is not installed as package appears to be valid" error appears. Unable to upgrade the app

    photo_2024-06-03 12 40 49

    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Jun 3, 2024 •
    edited
    Loading

    ISSUE 2 Cannot login the account after upgarde

    Tested on IOS

    Steps:

    1. Install build from some other PR (I used latest build from this PR test bugfix on windows #20296)
    2. Create/restore an account
    3. Install build from current PR on top of other build to test upgrade
    4. Try to login the account
    5. Observe the error

    Actual result: login results in error

    photo_2024-06-03 12 51 17

    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Jun 3, 2024 •
    edited
    Loading

    @cammellos I was able to test upgrade on Android using other PR, so ISSUE 1 seems to be not related to this PR.

    At the same time I am still facing ISSUE 2 on IOS cc @yqrashawn

    @yqrashawn yqrashawn self-assigned this Jun 3, 2024
    @yqrashawn
    Copy link
    Contributor

    IMG_5990

    able to reproduce ISSUE2 on iOS

    @yqrashawn
    Copy link
    Contributor

    Able to reproduce ISSUE1 on a one plus 5, it says app not installed when upgrade
    able to install and open the app if not upgrade from old one

    @yqrashawn
    Copy link
    Contributor

    Just checked the status-go diff, I guess this BackupDisabledDataDir is causing ISSUE2? status-im/status-go@v0.179.26...5186-cannot-login-on-windows#diff-3270068c140c83704dd9e117c7b423114a7f6b57307c42c1e68d1c210680fc52R1755-R1764

    I'll try debug build tomorrow.

    @Seitseman Seitseman mentioned this pull request Jun 3, 2024
    Closed
    @yqrashawn yqrashawn mentioned this pull request Jun 4, 2024
    Closed
    @yqrashawn
    Copy link
    Contributor

    Just tested upgrading from #20304 to #20316 on real device and the error in ISSUE2 is gone, able to log in successfully

    @pavloburykh
    Copy link
    Contributor

    @cammellos closing this one as there is a new PR pointing at the new go branch #20316

    @pavloburykh pavloburykh closed this Jun 4, 2024
    @pavloburykh pavloburykh mentioned this pull request Jun 5, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @qfrank qfrank qfrank approved these changes

    Assignees

    @cammellos cammellos

    @yqrashawn yqrashawn

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - Issues
    Projects
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @cammellos @status-im-auto @pavloburykh @yqrashawn @qfrank