fix: proper usage of CreateAccount RootDataDir #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (20)
|
igor-sirotin
force-pushed
the
fix/create-account-root-data-dir
branch
from
1a4543e
to
697e2be
Compare
|
Hey @igor-sirotin! Thanx for the PR. Could you please clarify, does this branch still valid #5255 or we should continue testing this new branch? Seems both branches a linked to the same issue #5186 |
|
@pavloburykh sorry for confusing. I closed #5284 now. |
igor-sirotin
changed the title
no worries, thank you for clarification @igor-sirotin |
yqrashawn
approved these changes
Jun 5, 2024
|
@igor-sirotin thanks for the PR, no issues from mobile side. Tested in status-im/status-mobile#20316 What has been tested:
|
igor-sirotin
force-pushed
the
fix/create-account-root-data-dir
branch
from
22eec2c
to
bdccd5d
Compare
igor-sirotin
force-pushed
the
fix/create-account-root-data-dir
branch
from
bdccd5d
to
020d422
Compare
igor-sirotin
added a commit
that referenced
this pull request
Jun 5, 2024
* fix_: introduce CreateAccount.RootDataDir * fix_: deprecate and remove ShhextConfig.BackupDisabledDataDir
igor-sirotin
added a commit
that referenced
this pull request
Jun 5, 2024
* fix_: introduce CreateAccount.RootDataDir * fix_: deprecate and remove ShhextConfig.BackupDisabledDataDir
jo-mut
pushed a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5186
CreateAccount.BackupDisabledDataDirCreateAccount.RootDataDir(with fallback toBackupDisabledDataDiruntil both clients update)nodeConfig.ShhextConfig.BackupDisabledDataDirto./by defaultloadNodeConfigand stop on errorShhextConfig.BackupDisabledDataDir. It was only used once as RootDataDir. Which was wrong and very confusing.