Avatars/Community Avatar Component #20147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (11)
|
clauxx
approved these changes
May 23, 2024
Comment on lines
3
to
11
| (def ?schema | ||
| [:=> | ||
| [:catn | ||
| [:props | ||
| [:map {:closed true} | ||
| [:size {:optional true} [:maybe [:enum :size-32 :size-24]]] | ||
| [:image :schema.common/image-source] | ||
| [:container-style {:optional true} [:maybe :map]]]]] | ||
| :any]) |
There was a problem hiding this comment.
The schema can be in the same ns with the component if it's small like this one. We tend to move it to a separate ns if you end up composing the schema from other smaller schema definitions, which takes some space and pollutes the component ns.
There was a problem hiding this comment.
Personally, I prefer keeping schemas in a separate file. In my workflow, I find it very easy to locate and work with component schemas when they are defined separately. However, I don't have strong objections to writing small schemas within the component view file itself. It seems we still haven't reached a consensus on this.
OmarBasem
approved these changes
May 23, 2024
| [react-native.core :as rn] | ||
| [schema.core :as schema])) | ||
|
|
||
| (defn view-internal |
J-Son89
approved these changes
May 23, 2024
ajayesivan
force-pushed
the
20130-community-avatar-component
branch
from
5431691
to
411f7d0
Compare
83% of end-end tests have passedFailed tests (6)Click to expandClass TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
ajayesivan
force-pushed
the
20130-community-avatar-component
branch
from
a742849
to
e731450
Compare
|
Hi @Francesca-G, could you please do a design review for this PR? Thanks! |
Hi @ajayesivan, thanks for the PR! E2E failures are not related |
ajayesivan
force-pushed
the
20130-community-avatar-component
branch
from
e731450
to
fd1f14c
Compare
J-Son89
added a commit
that referenced
this pull request
May 24, 2024
Fix hidden hook usage Improve logging for unsupported collectibles Fix re-rendering of collectibles in flat-list chore: clean up implementation and speed up animation remove apply animations to style chore: use default opacity chore: use default opacity chore: add issue to todo chore: use flex chore: flex Avatars/Community Avatar Component (#20147) Avatars/dApp Avatar Component (#20145) Update eth-archival pokt url Remove not implemented Notification settings from community longtap m… (#20169) pick between JSC & Hermes for Android (#20171) We implement both `JSC` and `Hermes` in build phase of `Android` which increases our `APK` size by ~ `2 MB`. This was fine before but currently we have to get below the `100 MB` limit. This commit implements the preferred engine after inferring `hermesEnabled` property from gradle.properties This property is modified at build time for release here https://github.com/status-im/status-mobile/blob/178d62bd276afffef5fe7a3f773e390d83336d9c/nix/mobile/android/build.nix#L17 and set for debug here https://github.com/status-im/status-mobile/blob/178d62bd276afffef5fe7a3f773e390d83336d9c/Makefile#L280 Which should further reduce the `APK` size by `2 MB`. [#19232] - Fix derivation path generation and keypair creation (#19531) * Add more default dependencies to slide button * Fix wallet account creation: derivation paths and keypairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20130
Summary
Implements the Avatars/Community Avatar component
Testing notes
Manual QA can be skipped since this PR only adds a quo component and doesn't introduce any changes outside Quo Preview.
Platforms
Areas that maybe impacted
None
Steps to test
Quo Preview -> Avatars -> Community Avatar
status: ready